Looking for NACKs? → nackamoto.com

Last updated at 2026-03-01 22:03 UTC

2026-03-01

#34705
kernel: Use fs:: namespace and unicode path in kernel tests
Concept ACK hebasto

2026-02-28

#34700
script: Fix undefined behavior in Clone() -- std::transform writes past end of empty vector
ACK maflcko
#34639
iwyu: Document or remove some `pragma: export` and other improvements
ACK maflcko
#34692
Bump dbcache to 1GB
ACK ajtowns
#34693
doc: Use relative markdown links
ACK kevkevinpal
#34692
Bump dbcache to 1GB
Concept ACK kevkevinpal
#34642
wallet: call SyncWithValidationInterfaceQueue after disconnecting chain notifications
utACK stickies-v

2026-02-27

#34690
test: Add missing timeout_factor to zmq socket
ACK achow101
#34661
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
ACK achow101
#34521
validation: fix UB in `LoadChainTip`
ACK fjahr
#34690
test: Add missing timeout_factor to zmq socket
Code Review ACK l0rinc
#34684
refactor: Enable -Wswitch in exhaustive switch'es, Enable -Wcovered-switch-default
ACK l0rinc
#34597
util: Fix UB in SetStdinEcho when ENOTTY
Code Review ACK l0rinc
#34683
RFC: Support a format description of our JSON-RPC interface
Concept ACK stickies-v

2026-02-26

#34683
RFC: Support a format description of our JSON-RPC interface
Concept ACK nervana21
#34521
validation: fix UB in `LoadChainTip`
ACK achow101
#34562
ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
ACK achow101
#34609
test: remove appveyor reference in comment
ACK maflcko
#34682
ci: fix vcpkg tools cache key collision between windows matrix jobs
ACK m3dwards
#34562
ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
ACK maflcko
#34683
RFC: Support a format description of our JSON-RPC interface
Concept ACK sedited
#34682
ci: fix vcpkg tools cache key collision between windows matrix jobs
ACK maflcko
#34661
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
ACK ismaelsadeeq

2026-02-25

#34671
doc: Update Guix install for Debian/Ubuntu
ACK achow101
#34562
ThreadPool follow-ups, proactive shutdown and HasReason dependency cleanup
ACK achow101
#34641
node: scale default `-dbcache` with system RAM
Concept ACK openoms
#34520
refactor: Add [[nodiscard]] to functions returning bool+mutable ref
Concept ACK sedited
#34458
net: Don't log own ips during discover
Tested ACK l0rinc

2026-02-24

#34561
wallet: rpc: manpage: fix example missing `fee_rate` argument
ACK achow101
#34608
test: Fix broken --valgrind handling after bitcoin wrapper
ACK achow101
#34521
validation: fix UB in `LoadChainTip`
Concept ACK sedited
#34653
test: improve txospender index tests code
ACK achow101
#34661
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
utACK Sjors
#34661
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
Concept ACK ismaelsadeeq
#34661
ipc mining: Prevent ``Assertion `m_node.chainman' failed`` errors on early startup
Concept ACK Sjors
#34660
ci: use LLVM 22 in sanitizer tasks
ACK maflcko
#34561
wallet: rpc: manpage: fix example missing `fee_rate` argument
Tested ACK kannapoix

2026-02-23

#34597
util: Fix UB in SetStdinEcho when ENOTTY
ACK achow101
#34655
fuzz: keep `coins_view` fuzzers within caller contracts
ACK achow101
#34653
test: improve txospender index tests code
ACK achow101
#34521
validation: fix UB in `LoadChainTip`
ACK achow101
#34646
Fix two issues in p2p_private_broadcast.py
ACK achow101
#34656
doc: clarify confusing `git range-diff` add/delete output
ACK Sjors
#34646
Fix two issues in p2p_private_broadcast.py
ACK l0rinc
#34615
mempool: expose optimality of mempool to log / rpc
reACK ismaelsadeeq
#34656
doc: clarify confusing `git range-diff` add/delete output
ACK maflcko

2026-02-21

#34615
mempool: expose optimality of mempool to log / rpc
ACK ajtowns
#34616
Cluster mempool: SFL cost model (take 2)
ACK ajtowns
#34523
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
ACK chriszeng1010
#34622
test: assert_debug_log timeouts follow-up
ACK achow101

2026-02-20

#34545
doc: Update Guix installation instructions for Debian/Ubuntu
ACK maflcko
#34605
build: define CMAKE_COMPILE_WARNING_AS_ERROR as a cache option
ACK fanquake
#34636
node: allocate index caches proportional to usage patterns
Concept ACK fjahr
#34572
cmake: Fix NetBSD-specific workaround for Boost
ACK fanquake
#34605
build: define CMAKE_COMPILE_WARNING_AS_ERROR as a cache option
ACK ajtowns
#34627
guix: use a temporary file over sponge, drop moreutils
Concept ACK davidgumberg

2026-02-19

#34571
test: Fix intermittent issues in feature_assumevalid.py
ACK achow101
#34549
net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures
ACK achow101
#34577
http: fix submission during shutdown race
ACK achow101
#34615
mempool: expose optimality of mempool to log / rpc
ACK ismaelsadeeq
#34614
ci: Put space and non-ASCII char in scratch dir
Concept ACK hebasto
#34623
Update secp256k1 subtree to latest master
Concept ACK hebasto
#34568
mining: Break compatibility with existing IPC mining clients
Concept ACK ismaelsadeeq
#34571
test: Fix intermittent issues in feature_assumevalid.py
ACK maflcko
#34490
wallet: Follow-ups to create/load split (#32636)
Concept ACK w0xlt

2026-02-18

#34608
test: Fix broken --valgrind handling after bitcoin wrapper
Concept ACK theStack
#34550
guix: update time-machine to 4d0fe6995b3acf0a807a125cd0d4488bd59cb01b
ACK pinheadmz
#34568
mining: Break compatibility with existing IPC mining clients
ACK Sjors
#34520
refactor: Add [[nodiscard]] to functions returning bool+mutable ref
ACK yuvicc

2026-02-17

#34486
net: Reduce local network activity when networkactive=0
Concept ACK brunoerg
#34549
net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures
Concept ACK gmaxwell

2026-02-16

#34575
test: Avoid empty errmsg in JSONRPCException
utACK ismaelsadeeq
#34583
ci: [refactor] Drop last use of pwsh
utACK m3dwards

2026-02-14

#34489
index: batch db writes during initial sync
Concept ACK arejula27
#34580
build: Add a compiler minimum version check
Concept ACK w0xlt

2026-02-13

#34582
rpc: Properly parse -rpcworkqueue/-rpcthreads
Concept ACK pinheadmz
#34548
ci: Add and use ci-windows-cross.py helper
ACK maflcko
#34546
kernel: Avoid duplicating symbols in the kernel library
ACK fanquake
#34567
test: Add package RBF test with deduplicated parent
ACK HowHsu

2026-02-12

#34489
index: batch db writes during initial sync
ACK l0rinc
#34568
mining: Break compatibility with existing IPC mining clients
Concept ACK Sjors
#34565
refactor: extract BlockDownloadManager from PeerManagerImpl
Concept ACK 0xbrito

2026-02-11

#34565
refactor: extract BlockDownloadManager from PeerManagerImpl
Concept ACK sedited
#34457
wallet: add private broadcast support for wallet transactions
Concept ACK Bicaru20
#34549
net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures
ACK 0xB10C
#34559
ci: split vcpkg tools cache into restore/save
ACK maflcko
#34552
fees: refactor: separate feerate format from fee estimate mode
ACK l0rinc
#34554
build: avoid exporting secp256k1 symbols
Concept ACK stickies-v

2026-02-10

#34551
ci: Extend diff context for clang-format
Code Review ACK l0rinc
#34546
kernel: Avoid duplicating symbols in the kernel library
ACK theuni
#34546
kernel: Avoid duplicating symbols in the kernel library
ACK w0xlt
#34551
ci: Extend diff context for clang-format
ACK maflcko
#34550
guix: update time-machine to 4d0fe6995b3acf0a807a125cd0d4488bd59cb01b
Concept ACK hebasto
#34480
wallet: don't back-date locktime below input locktime
Concept ACK rkrux

2026-02-09

#34512
rpc: add coinbase_tx field to getblock
utACK ajtowns
#34544
wallet: Disallow wallet names that are paths including `..` and `.` elements
Concept ACK davidgumberg
#34500
ci: Print verbose Windows CI build failure
ACK m3dwards
#34523
doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false
ACK l0rinc
#34536
[29.x] Finalise v29.3
ACK fanquake

2026-02-08

#34534
rpc: Manual prune lock management (Take 2)
Concept ACK sedited

2026-02-07

#34532
doc: discourage Tor-only node operation in tor.md
Concept ACK aandia
#34416
Add nullptr-check to CChain::Contains(), tests
ACK HowHsu
#34521
validation: fix UB in `LoadChainTip`
Concept ACK Jhackman2019
#34486
net: Reduce local network activity when networkactive=0
Concept ACK Jhackman2019
#34483
refactor: Use SpanReader over DataStream
ACK achow101

2026-02-06

#34524
refactor: [rpc] Remove confusing and brittle integral casts (take 2)
ACK Sjors
#34465
refactor: separate log generation from log handling
ACK l0rinc
#34421
ci: add Chimera Linux LTO config
ACK maflcko
#34452
test: split interface_ipc.py
utACK ismaelsadeeq
#34520
refactor: Add [[nodiscard]] to functions returning bool+mutable ref
ACK HowHsu
#34492
ci: Drop valgrind fuzz from GHA matrix
ACK fanquake
#34437
rpc: `uptime` should begin on application start
ACK achow101

2026-02-05

#34437
rpc: `uptime` should begin on application start
Tested ACK carloantinarella
#34504
build: replace `WERROR` with `CMAKE_COMPILE_WARNING_AS_ERROR`
ACK maflcko
#34517
drop my key from trusted-keys
ACK achow101
#34517
drop my key from trusted-keys
Concept ACK sedited
#34517
drop my key from trusted-keys
Concept ACK luke-jr
#34504
build: replace `WERROR` with `CMAKE_COMPILE_WARNING_AS_ERROR`
ACK purpleKarrot
#34512
rpc: add coinbase_tx field to getblock
Concept ACK 0xB10C
#34511
test: fully reset the state of CConnman in tests
ACK maflcko
#34510
doc: fix broken bpftrace installation link
ACK 0xB10C
#34416
Add nullptr-check to CChain::Contains(), tests
ACK HowHsu
#34510
doc: fix broken bpftrace installation link
ACK maflcko
#34469
consensus/test/doc: cover errors in `CheckTxInputs` with unit tests
ACK maflcko

2026-02-04

#34500
ci: Print verbose Windows CI build failure
Concept ACK m3dwards
#34504
build: replace `WERROR` with `CMAKE_COMPILE_WARNING_AS_ERROR`
ACK maflcko
#34500
ci: Print verbose Windows CI build failure
Concept ACK l0rinc
#34495
Replace boost signals with minimal compatible implementation
Concept ACK fjahr
#34495
Replace boost signals with minimal compatible implementation
Concept ACK fanquake
#34498
iwyu: Fix patch to prefer `<cstdint>`
ACK maflcko

2026-02-03

#34493
contrib: Remove valgrind suppression for bug 472219
ACK fanquake
#34492
ci: Drop valgrind fuzz from GHA matrix
ACK l0rinc
#34470
Bump leveldb subtree and remove UB workaround in CI
ACK fanquake
#34489
index: batch db writes during initial sync
Concept ACK l0rinc
#34481
Update secp256k1 subtree to latest master
ACK maflcko
#34470
Bump leveldb subtree and remove UB workaround in CI
Code Review ACK l0rinc
#34486
net: Reduce local network activity when networkactive=0
Concept ACK fanquake
#34474
ci: update ccache to improve hitrate
ACK maflcko
#34483
refactor: Use SpanReader over DataStream
Concept ACK davidgumberg
#34472
bench: add script verification benchmark for P2TR key path spends
Concept ACK w0xlt

2026-02-02

#34483
refactor: Use SpanReader over DataStream
Concept ACK sipa
#34486
net: Reduce local network activity when networkactive=0
Concept ACK sedited
#34483
refactor: Use SpanReader over DataStream
Concept ACK stickies-v
#34470
Bump leveldb subtree and remove UB workaround in CI
Concept ACK hebasto
#34478
ci: Fix LLVM repository signature failure
ACK maflcko
#34472
bench: add script verification benchmark for P2TR key path spends
Concept ACK l0rinc

2026-02-01

#34470
Bump leveldb subtree and remove UB workaround in CI
Concept ACK fanquake

2026-01-31

#34464
Change BlockRequestAllowed() to take ref (minor refactor)
Tested ACK l0rinc
#34464
Change BlockRequestAllowed() to take ref (minor refactor)
ACK maflcko

2026-01-30

#34457
wallet: add private broadcast support for wallet transactions
Concept ACK andrewtoth
#34454
wallet: Rename `RecordType::DELETE` to `RecordType::DELETE_FLAG`
ACK achow101
#34462
util: Drop *BSD headers in `batchpriority.cpp`
ACK maflcko
#34454
wallet: Rename `RecordType::DELETE` to `RecordType::DELETE_FLAG`
ACK maflcko
#34454
wallet: Rename `RecordType::DELETE` to `RecordType::DELETE_FLAG`
ACK maflcko
#34460
iwyu: Update mappings
ACK maflcko

2026-01-29

#34451
rpc: fix race condition in gettxoutsetinfo
Concept ACK fjahr
#34434
miniscript: correct and_v() properties
ACK achow101
#34425
test: Fix all races after a socket is closed gracefully
Concept ACK davidgumberg
#34437
rpc: `uptime` should begin on application start
ACK maflcko
#34445
fuzz: Use `__AFL_SHM_ID` for naming test directories
ACK maflcko
#34439
qa: Drop recursive deletes from test code, add lint checks.
Concept ACK l0rinc

2026-01-28

#34434
miniscript: correct and_v() properties
Code Review ACK sipa
#34430
ci: mount git directory as writable in linter
ACK maflcko

2026-01-27

#34417
log: Print warning about privacy-sensitive log info unconditionally
ACK l0rinc

2026-01-26

#34413
doc: Remove outdated -fdebug-prefix-map section in dev notes
ACK l0rinc