Looking for NACKs? → nackamoto.com

Last updated at 2025-11-10 10:04 UTC

2025-11-10

#33824
ci: Enable experimental kernel stuff in most CI tasks
Concept ACK stickies-v
#33826
scripted-diff: Remove obsolete comment
ACK maflcko

2025-11-08

#33826
scripted-diff: Remove obsolete comment
Code Review ACK l0rinc

2025-11-07

#33818
ci: Extend tidy job to cover kernel code
ACK maflcko

2025-11-06

#33724
refactor: Return uint64_t from GetSerializeSize
ACK l0rinc
#33786
script: remove dead code in `CountWitnessSigOps`
ACK maflcko
#33770
init: Require explicit -asmap filename
ACK jurraca
#33796
kernel: Expose `CheckTransaction` consensus validation function
Concept ACK TheCharlatan
#33793
test: move create_malleated_version() to messages.py for reuse
ACK l0rinc
#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
ACK purpleKarrot

2025-11-05

#33786
script: remove dead code in `CountWitnessSigOps`
ACK kevkevinpal
#33793
test: move create_malleated_version() to messages.py for reuse
ACK maflcko
#33791
kernel: Use enumeration type for flags argument
ACK alexanderwiederin
#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
ACK maflcko
#33789
doc: add cmake help option in Windows build docs
ACK waketraindev
#33768
refactor: remove dead branches in `SingletonClusterImpl`
ACK instagibbs
#33775
guix: use GCC 14.3.0 over 13.3.0
ACK maflcko

2025-11-04

#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
Code Review ACK l0rinc
#33781
clang-tidy: Remove no longer needed NOLINT
ACK l0rinc
#33781
clang-tidy: Remove no longer needed NOLINT
ACK maflcko
#33780
guix: disable libsanitizer in Linux GCC build
ACK maflcko
#33778
depends: add zeromq patch to fix mingw CMake file install location
Concept ACK hebasto
#33714
random: scope environ extern to macOS, BSDs and Illumos
ACK l0rinc
#33626
ci: run native fuzz with MSAN job
ACK maflcko
#33775
guix: use GCC 14.3.0 over 13.3.0
Concept ACK hebasto
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
ACK maflcko
#33728
test: Add bitcoin-chainstate test for assumeutxo functionality
ACK frankomosh

2025-11-03

#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
utACK optout21
#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
utACK optout21
#33602
[IBD] coins: reduce lookups in dbcache layer propagation
utACK optout21
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
Concept ACK fanquake
#33680
validation: do not wipe utxo cache for stats/scans/snapshots
utACK optout21
#33754
ci: gha: Set debug_pull_request_number_str annotation
Code Review ACK l0rinc
#33754
ci: gha: Set debug_pull_request_number_str annotation
ACK maflcko

2025-11-01

#33665
wallet: remove redundant sighash calculation in Musig2 signing flow
Concept ACK optout21
#33711
transaction: Adding script witness to ToString for CTxIn
Concept ACK optout21

2025-10-31

#33757
refactor: make script Solver's often-unused solutions parameter optional
Code Review ACK Raimo33
#33754
ci: gha: Set debug_pull_request_number_str annotation
ACK davidgumberg
#33753
test: Format strings in `test_runner`
ACK maflcko
#33738
log: avoid collecting `GetSerializeSize` data when compact block logging is disabled
Concept ACK 0xB10C
#33702
contrib: Remove brittle, confusing and redundant UTF8 encoding from Python IO
Concept ACK laanwj
#33676
interfaces: enable cancelling running `waitNext` calls
Concept ACK Sjors
#33753
test: Format strings in `test_runner`
ACK maflcko
#33746
ci: Add missing python3-dev package for riscv64
ACK fanquake

2025-10-30

#33746
ci: Add missing python3-dev package for riscv64
ACK fanquake
#33728
test: Add bitcoin-chainstate test for assumeutxo functionality
Concept ACK yuvicc
#33744
ci: Fix lint runner selection (and docker cache)
ACK maflcko
#33738
log: avoid collecting `GetSerializeSize` data when compact block logging is disabled
Concept ACK TheCharlatan

2025-10-29

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK delta1
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK l0rinc
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK delta1

2025-10-28

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK john-moffett
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK davidgumberg
#33724
refactor: Return uint64_t from GetSerializeSize
Concept ACK l0rinc
#33683
refactor/doc: Add blockman param to GetTransaction doc comment
reACK kevkevinpal
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK l0rinc
#33693
ci: use pycapnp 2.2.1
ACK maflcko
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK onyxcoyote
#33677
ci: Retry image building once on failure
Concept ACK davidgumberg
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK frodrik-froggo
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK gmaxwell
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK john-moffett
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK hsjoberg
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK niteshbalusu11
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK polespinasa
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK Symphonic3
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK jlopp
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK achow101
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK waketraindev
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK delta1
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK reardencode
#33724
refactor: Return uint64_t from GetSerializeSize
Concept ACK darosior
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK dergoegge
#33676
interfaces: enable cancelling running `waitNext` calls
Code Review ACK furszy

2025-10-27

#33689
http: replace WorkQueue and single threads handling for ThreadPool
ACK TheCharlatan
#33477
Rollback for dumptxoutset without invalidating blocks
ACK enirox001

2025-10-25

#33701
test: add case where `TOTAL_TRIES` is exceeded yet solution remains
Concept ACK alvroble

2025-10-24

#33683
refactor/doc: Add blockman param to GetTransaction doc comment
ACK l0rinc
#33677
ci: Retry image building once on failure
ACK kevkevinpal
#33483
CMake: Add dynamic test discovery
Concept ACK willcl-ark
#33677
ci: Retry image building once on failure
reACK l0rinc
#33674
ci: Doc ASLR workaround for sanitizer tasks
ACK Sjors
#33677
ci: Retry image building once on failure
Code Review ACK l0rinc
#33693
ci: use pycapnp 2.2.1
ACK maflcko

2025-10-23

#33689
http: replace WorkQueue and single threads handling for ThreadPool
Concept ACK pinheadmz
#33506
test: sock: Enable socket pair tests on Windows
Concept ACK laanwj
#33666
ci: Drop libFuzzer from msan fuzz task
Concept ACK dergoegge
#33674
ci: Doc ASLR workaround for sanitizer tasks
ACK fanquake
#33683
refactor/doc: Add blockman param to GetTransaction doc comment
ACK maflcko

2025-10-22

#33662
doc: add AGENTS.md
ACK kevkevinpal
#33679
test: set number of RPC server threads to 2
ACK kevkevinpal
#33679
test: set number of RPC server threads to 2
ACK l0rinc
#33679
test: set number of RPC server threads to 2
ACK maflcko
#33593
guix: Use UCRT runtime for Windows release binaries
Concept ACK laanwj
#33631
init: Split file path handling out of -asmap option
Concept ACK laanwj
#33639
ci: Only write docker build images to Cirrus cache
reACK cedwies
#33675
randomenv: drop self define of 'environ'
Concept ACK laanwj
#33570
randomenv: Fix MinGW dllimport warning for `environ`
utACK sipa
#33665
wallet: remove redundant sighash calculation in Musig2 signing flow
Concept ACK Raimo33
#33639
ci: Only write docker build images to Cirrus cache
ACK m3dwards
#33670
test: Use unassigned p2p_port instead of hardcoded 60000 in p2p_i2p_ports.py
Code Review ACK laanwj

2025-10-21

#33483
CMake: Add dynamic test discovery
Concept ACK hebasto
#33669
Add libbitcoinkernel example files
Concept ACK TheCharlatan
#33666
ci: Drop libFuzzer from msan fuzz task
ACK kevkevinpal
#33657
rest: allow reading partial block data from storage
Concept ACK optout21
#33662
doc: add AGENTS.md
ACK maflcko
#33567
node: change a tx-relay on/off flag to enum
Code Review ACK laanwj

2025-10-20

#33661
test: Add test on skip heights in CBlockIndex
Concept ACK l0rinc
#33662
doc: add AGENTS.md
Concept ACK m3dwards
#33600
refactor: Construct g_verify_flag_names on first use
ACK ajtowns
#33633
test: [move-only] binary utils to utils.py
ACK yuvicc

2025-10-17

#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
ACK Raimo33

2025-10-16

#33641
Update leveldb subtree to latest master
ACK cedwies
#33633
test: [move-only] binary utils to utils.py
Concept ACK l0rinc
#33641
Update leveldb subtree to latest master
ACK l0rinc
#33613
[28.x] Backport & finalise 28.3
ACK marcofleon
#33633
test: [move-only] binary utils to utils.py
ACK Sjors
#33519
Update libmultiprocess subtree in 30.x branch
ACK Sjors
#33565
net_processing: rename RelayTransaction to better describe what it does
reACK optout21

2025-10-15

#33633
test: [move-only] binary utils to utils.py
ACK kevkevinpal
#33567
node: change a tx-relay on/off flag to enum
ACK kevkevinpal
#33565
net_processing: rename RelayTransaction to better describe what it does
utACK glozow
#33567
node: change a tx-relay on/off flag to enum
ACK optout21
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
ACK maflcko

2025-10-14

#33630
doc: correct topology requirements in submitpackage helptext
ACK kevkevinpal
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
Tested ACK l0rinc
#33626
ci: run native fuzz with MSAN job
Concept ACK dergoegge
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
ACK maflcko
#33566
miner: fix empty mempool case for waitNext()
ACK optout21
#33612
test: change log rate limit version gate
ACK maflcko
#33623
doc: document capnproto and libmultiprocess deps in 29.x
Concept ACK sipa
#33566
miner: fix empty mempool case for waitNext()
Concept ACK optout21
#33602
[IBD] coins: reduce lookups in dbcache layer propagation
Concept ACK optout21
#33604
p2p: Allow block downloads from peers without snapshot block after assumeutxo validation
Concept ACK Raimo33
#33517
multiprocess: Fix high overhead from message logging
ACK Sjors
#33508
ci: fix buildx gha cache authentication on forks
ACK maflcko

2025-10-13

#33555
build: Bump clang minimum supported version to 17
Concept ACK janb84
#33612
test: change log rate limit version gate
ACK kevkevinpal
#33566
miner: fix empty mempool case for waitNext()
Concept ACK Raimo33
#33557
[28.x] 28.3rc2
ACK marcofleon

2025-10-12

#33604
p2p: Allow block downloads from peers without snapshot block after assumeutxo validation
Concept ACK TheCharlatan
#33600
refactor: Construct g_verify_flag_names on first use
ACK kevkevinpal

2025-10-10

#33573
doc: bump the template macOS version
ACK l0rinc
#33573
doc: bump the template macOS version
ACK maflcko
#33551
[29.x] Finalise 29.2
ACK instagibbs
#33592
contrib: remove deprecated --deep signing from macdeployqtplus
Concept ACK hebasto
#33569
refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions
ACK Dorex45
#33559
[30.x] Finalise v30.0
ACK Dorex45
#33559
[30.x] Finalise v30.0
ACK l0rinc

2025-10-09

#33577
Revert "depends: Update URL for `qrencode` package source tarball"
ACK maflcko
#33568
doc: how to update a subtree
ACK achow101
#33559
[30.x] Finalise v30.0
ACK achow101
#33477
Rollback for dumptxoutset without invalidating blocks
Concept ACK theStack
#33559
[30.x] Finalise v30.0
ACK instagibbs
#33577
Revert "depends: Update URL for `qrencode` package source tarball"
utACK m3dwards
#33568
doc: how to update a subtree
ACK fjahr
#33584
ci: upgrade GitHub Action to download-artifact@v5
ACK willcl-ark
#33565
net_processing: rename RelayTransaction to better describe what it does
ACK andrewtoth
#33584
ci: upgrade GitHub Action to download-artifact@v5
ACK maflcko
#33581
ci: Properly include $FILE_ENV in DEPENDS_HASH
ACK maflcko

2025-10-08

#33553
validation: Improve warnings in case of chain corruption
Concept ACK hodlinator
#33573
doc: bump the template macOS version
ACK l0rinc
#33549
ci: Add macOS cross task for arm64-apple-darwin
utACK Sjors
#33565
net_processing: rename RelayTransaction to better describe what it does
ACK optout21
#33569
refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions
ACK purpleKarrot
#33568
doc: how to update a subtree
ACK yuvicc

2025-10-07

#33494
depends: Update URL for `qrencode` package source tarball
ACK achow101
#33515
Improve LastCommonAncestor performance + add tests
ACK achow101
#33518
Update libmultiprocess subtree to support reduced logging
utACK Sjors
#33561
[28.x] ci: Fix Qt 5.15 URL
ACK fanquake

2025-10-06

#33550
Fix windows libc++ `fs::path` `fstream` compile errors
ACK maflcko
#33540
argsman, cli: GNU-style command-line option parsing (allows options after non-option arguments)
Concept ACK ryanofsky
#33515
Improve LastCommonAncestor performance + add tests
ACK optout21

2025-10-04

#33480
ci: Turn CentOS config into Alpine musl config
Concept ACK dergoegge

2025-10-03

#33534
[29.x] Finalise 29.2rc2
reACK davidgumberg
#33534
[29.x] Finalise 29.2rc2
ACK davidgumberg
#33474
[29.x] Backports
ACK luke-jr

2025-10-02

#33489
build: Drop support for EOL macOS 13
Code Review ACK l0rinc
#33517
multiprocess: Fix high overhead from message logging
Concept ACK Raimo33
#33511
init: Fix Ctrl-C shutdown hangs during wait calls
ACK Sjors
#33517
multiprocess: Fix high overhead from message logging
Concept ACK TheCharlatan

2025-10-01

#33498
p2p: Mitigate GETADDR fingerprinting by setting address timestamps to a fixed value
Concept ACK sipa

2025-09-30

#33476
[28.x] backports + 28.3rc1
ACK achow101
#33494
depends: Update URL for `qrencode` package source tarball
ACK m3dwards
#33498
p2p: Mitigate GETADDR fingerprinting by setting address timestamps to a fixed value
Concept ACK jonatack
#33508
ci: fix buildx gha cache authentication on forks
ACK m3dwards
#33509
ci: Check macos-cross executables on macOS
Concept ACK katesalazar
#33504
Mempool: Do not enforce TRUC checks on reorg
ACK sdaftuar
#33487
ci: use latest versions of lint deps
ACK maflcko

2025-09-29

#33489
build: Drop support for EOL macOS 13
ACK katesalazar
#33487
ci: use latest versions of lint deps
ACK maflcko
#33485
test: set par=2 in default config for functional test framework
ACK maflcko

2025-09-27

#33480
ci: Turn CentOS config into Alpine musl config
Concept ACK RandyMcMillan

2025-09-25

#33480
ci: Turn CentOS config into Alpine musl config
Concept ACK willcl-ark