Looking for NACKs? → nackamoto.com

Last updated at 2025-09-21 06:04 UTC

2025-09-21

#33299
wallet: reduce unconditional logging during load
Concept ACK l0rinc

2025-09-19

#33388
test: don't throw from the destructor of DebugLogHelper
reACK l0rinc
#33422
build: Remove lingering Windows registry & shortcuts (#32132 follow-up)
ACK achow101
#33435
system: improve handling around GetTotalRAM()
ACK l0rinc

2025-09-18

#33422
build: Remove lingering Windows registry & shortcuts (#32132 follow-up)
ACK achow101
#33378
Remove unnecessary casts when calling socket operations
ACK achow101
#33412
Update libmultiprocess subtree to fix intermittent mptest hang
ACK Sjors
#33427
rpc: Always return per-wtxid entries in submitpackage tx-results
Concept ACK instagibbs
#33297
cmake: Inherit WERROR setting for secp256k1 build
Concept ACK luke-jr
#33378
Remove unnecessary casts when calling socket operations
ACK Raimo33

2025-09-17

#33333
coins: warn on oversized `-dbcache`
ACK achow101
#33299
wallet: reduce unconditional logging during load
ACK achow101
#33302
ci: disable cirrus cache in 32bit arm job
ACK m3dwards
#33410
coinstats: avoid unnecessary Coin copy in ApplyHash
Concept ACK Raimo33
#33420
test: Avoid interface_ipc.py Duplicate ID errors
Concept ACK Sjors
#33411
ci: re-add Valgrind job to the CI
Concept ACK willcl-ark
#33336
log: always print initial script verification state
ACK TheCharlatan

2025-09-16

#33399
key: use static context for libsecp256k1 calls where applicable
Concept ACK Raimo33
#33247
build: Remove deprecated CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings
Code Review ACK purpleKarrot
#33391
test: Prevent disk space warning during node_init_tests
ACK achow101

2025-09-15

#33395
net: do not apply whitelist permissions to onion inbounds
ACK achow101
#33380
test: Add submitblock test in interface_ipc
ACK Sjors
#33388
test: don't throw from the destructor of DebugLogHelper
ACK Crypt-iQ
#33380
test: Add submitblock test in interface_ipc
ACK Sjors
#33336
log: always print initial script verification state
ACK w0xlt

2025-09-13

#33353
log: show reindex progress in `ImportBlocks`
Concept ACK Raimo33

2025-09-12

#33333
coins: warn on oversized `-dbcache`
Concept ACK willcl-ark

2025-09-11

#33243
test: Fix CLI_MAX_ARG_SIZE issues
ACK achow101
#33332
common: Make arith_uint256 trivially copyable
ACK achow101
#33321
kernel: make blockTip index const
ACK achow101
#33141
test: Remove polling loop from test_runner (take 2)
ACK achow101
#33364
ci: always use tag for LLVM checkout
ACK davidgumberg
#33333
coins: warn on oversized `-dbcache`
Concept ACK willcl-ark
#33332
common: Make arith_uint256 trivially copyable
ACK l0rinc
#33332
common: Make arith_uint256 trivially copyable
ACK Raimo33
#33335
txgraph: randomize order of same-feerate distinct-cluster transactions
Concept ACK instagibbs
#33286
doc: update multisig tutorial to use multipath descriptors
reACK kannapoix

2025-09-10

#33354
txgraph: use enum Level instead of bool main_only
ACK instagibbs
#33354
txgraph: use enum Level instead of bool main_only
Concept ACK instagibbs

2025-09-09

#33231
net: Prevent node from binding to the same `CService`
ACK achow101
#33231
net: Prevent node from binding to the same `CService`
utACK sipa
#33275
Release: 30.0 translations update
ACK fanquake
#33229
multiprocess: Don't require bitcoin -m argument when IPC options are used
ACK Sjors
#33342
guix: strip binaries in libexec
ACK achow101
#33296
net: check for empty header before calling FillBlock
ACK achow101

2025-09-08

#33324
RFC: blocks: add `-reobfuscate-blocks` arg to xor existing blk/rev on startup
Concept ACK stickies-v
#33296
net: check for empty header before calling FillBlock
reACK instagibbs
#33338
net: Add interrupt to pcp retry loop
ACK achow101
#33312
clang-tidy: Disable `UndefinedBinaryOperatorResult` check in `src/ipc`
ACK achow101
#33340
Fix benchmark CSV output
Code Review ACK Raimo33
#33319
ci: reduce runner sizes on various jobs
ACK m3dwards
#33342
guix: strip binaries in libexec
Concept ACK hebasto
#33312
clang-tidy: Disable `UndefinedBinaryOperatorResult` check in `src/ipc`
ACK fjahr
#33339
doc: move release notes to wiki pre branch off
utACK fridokus
#33117
Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications
ACK TheCharlatan
#33333
coins: warn on oversized `-dbcache`
Concept ACK TheCharlatan
#33324
RFC: blocks: add `-reobfuscate-blocks` arg to xor existing blk/rev on startup
Concept ACK TheCharlatan
#33312
clang-tidy: Disable `UndefinedBinaryOperatorResult` check in `src/ipc`
ACK Sjors
#33333
coins: warn on oversized `-dbcache`
Concept ACK Sjors
#33332
common: Make arith_uint256 trivially copyable
Concept ACK Raimo33

2025-09-06

#33192
refactor: unify container presence checks (without PR conflicts)
ACK Raimo33
#33319
ci: reduce runner sizes on various jobs
ACK kevkevinpal
#33322
Update libmultiprocess subtree to improve build and logs
ACK Sjors

2025-09-05

#33142
test: Run bench sanity checks in parallel with functional tests
Concept ACK l0rinc
#33201
Add functional test for IPC interface
ACK Sjors
#33231
net: Prevent node from binding to the same `CService`
ACK l0rinc
#33286
doc: update multisig tutorial to use multipath descriptors
ACK kannapoix

2025-09-04

#33311
net: Quiet down logging when router doesn't support natpmp/pcp
ACK achow101
#33278
cmake: make missing Python interpreter behaviour more explicit
ACK davidgumberg
#33311
net: Quiet down logging when router doesn't support natpmp/pcp
Tested ACK davidgumberg
#33311
net: Quiet down logging when router doesn't support natpmp/pcp
utACK sipa
#33311
net: Quiet down logging when router doesn't support natpmp/pcp
utACK willcl-ark
#33296
net: check for empty header before calling FillBlock
Concept ACK instagibbs
#33145
CI: silent merge check
Concept ACK maflcko

2025-09-03

#33286
doc: update multisig tutorial to use multipath descriptors
Concept ACK w0xlt
#33291
ci: cd into BASE_BUILD_DIR for GetCMakeLogFiles
ACK maflcko
#33235
build: set ENABLE_IPC to OFF when fuzzing
ACK marcofleon
#33286
doc: update multisig tutorial to use multipath descriptors
Concept ACK Sjors

2025-09-02

#33224
doc: unify `datacarriersize` warning with release notes
ACK achow101
#33201
Add functional test for IPC interface
ACK Sjors
#33274
kernel: chainparams & headersync updates for 30.0
ACK achow101
#33201
Add functional test for IPC interface
ACK Sjors
#33144
build: Set AUTHOR_WARNING on warnings
ACK stickies-v

2025-09-01

#33274
kernel: chainparams & headersync updates for 30.0
ACK Sjors

2025-08-30

#33268
wallet: Identify transactions spending 0-value outputs, and add tests for anchor outputs in a wallet
Tested ACK jsarenik

2025-08-29

#33268
wallet: Identify transactions spending 0-value outputs, and add tests for anchor outputs in a wallet
Tested ACK jsarenik
#33210
fuzz: enhance wallet_fees by mocking mempool stuff
ACK maflcko
#33172
test: p2p block malleability
ACK maflcko
#33253
Revert compact block cache inefficiencies
ACK l0rinc

2025-08-28

#33189
rpc: followups for min fee changes
ACK ajtowns
#33264
threading: reduce the scope of lock in getblocktemplate
ACK maflcko
#33253
Revert compact block cache inefficiencies
ACK cedwies
#33258
ci: use LLVM 21
ACK maflcko
#33264
threading: reduce the scope of lock in getblocktemplate
ACK maflcko
#33184
test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py
Concept ACK kannapoix

2025-08-27

#33261
ci: return to using dash in CentOS job
ACK davidgumberg
#33261
ci: return to using dash in CentOS job
ACK maflcko
#33259
rpc, logging: add backgroundvalidation to getblockchaininfo
Concept ACK yuvicc

2025-08-26

#33224
doc: unify `datacarriersize` warning with release notes
ACK kevkevinpal
#33253
Revert compact block cache inefficiencies
Tested ACK polespinasa
#33251
[29.x] backport #33212
ACK achow101
#33253
Revert compact block cache inefficiencies
ACK achow101
#33230
cli: Handle arguments that can be either JSON or string
ACK kevkevinpal
#33243
test: Fix CLI_MAX_ARG_SIZE issues
ACK cedwies
#33199
fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates
Concept ACK kevkevinpal

2025-08-25

#33241
Update libmultiprocess subtree to fix build issues
ACK achow101
#33243
test: Fix CLI_MAX_ARG_SIZE issues
ACK cedwies
#33241
Update libmultiprocess subtree to fix build issues
ACK Sjors

2025-08-23

#33230
cli: Handle arguments that can be either JSON or string
ACK kannapoix
#33230
cli: Handle arguments that can be either JSON or string
Concept ACK nervana21

2025-08-22

#33231
net: Prevent node from binding to the same `CService`
Concept ACK cedwies
#33237
doc: use new block_to_connect parameter name
ACK purpleKarrot
#33224
doc: unify `datacarriersize` warning with release notes
ACK ajtowns

2025-08-21

#33222
miner: clamp options instead of asserting
ACK achow101
#33212
index: Don't commit state in BaseIndex::Rewind
ACK achow101
#33222
miner: clamp options instead of asserting
ACK Sjors
#33236
doc: Remove wrong and redundant doxygen tag
ACK cedwies
#33217
depends: remove xinerama extension from libxcb
Concept ACK hebasto
#33224
doc: unify `datacarriersize` warning with release notes
Code Review ACK ryanofsky
#33233
doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"
ACK maflcko
#33212
index: Don't commit state in BaseIndex::Rewind
Concept ACK fjahr
#33233
doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"
Code Review ACK ryanofsky
#33233
doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"
ACK maflcko
#33229
multiprocess: Don't require bitcoin -m argument when IPC options are used
Concept ACK Sjors
#33231
net: Prevent node from binding to the same `CService`
Concept ACK yuvicc

2025-08-20

#33226
[29.x] 33106 backport and final changes for rc2
Concept ACK darosior
#33226
[29.x] 33106 backport and final changes for rc2
Concept ACK instagibbs
#33225
[29.x] Backport logging ratelimiting
ACK Crypt-iQ
#33225
[29.x] Backport logging ratelimiting
utACK instagibbs
#33224
doc: unify `datacarriersize` warning with release notes
ACK cedwies

2025-08-19

#33181
guix: build for Linux HOSTS with `-static-libgcc`
Concept ACK theuni
#33211
test: modify logging_filesize_rate_limit params
ACK janb84
#33211
test: modify logging_filesize_rate_limit params
ACK maflcko

2025-08-18

#33190
build: Enable ENABLE_IPC option by default
ACK sipa

2025-08-16

#33201
Add functional test for IPC interface
Concept ACK Sjors

2025-08-15

#33201
Add functional test for IPC interface
Concept ACK ryanofsky
#33200
cmake: Introduce translate.cmake script for translate target
Concept ACK TheCharlatan
#33200
cmake: Introduce translate.cmake script for translate target
Concept ACK hebasto
#33190
build: Enable ENABLE_IPC option by default
ACK josibake
#33193
Release: Prepare "Translation string freeze" step
Concept ACK ismaelsadeeq
#33183
validation: rename block script verification error from "mandatory" to "block"
utACK Crypt-iQ
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK gmaxwell
#33190
build: Enable ENABLE_IPC option by default
Concept ACK Sjors
#33183
validation: rename block script verification error from "mandatory" to "block"
utACK ajtowns

2025-08-14

#33183
validation: rename block script verification error from "mandatory" to "block"
ACK davidgumberg
#33183
validation: rename block script verification error from "mandatory" to "block"
utACK fjahr
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK achow101
#33190
build: Enable ENABLE_IPC option by default
Concept ACK TheCharlatan
#33169
interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator
ACK achow101
#33179
doc: update wallet build instruction
ACK achow101

2025-08-12

#33179
doc: update wallet build instruction
ACK jonatack
#33169
interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator
Concept ACK bc1cindy
#33171
ci: Update `actions/checkout` version
ACK bc1cindy
#33172
test: p2p block malleability
ACK bc1cindy

2025-08-10

#33156
cmake: Do not require Python to build GUI
ACK Sammie05

2025-08-09

#33158
macdeploy: avoid use of `Bitcoin Core` in Linux cross build
Concept ACK hodlinator
#33162
test: fix scripts in `blockfilter_basic_test`
Concept ACK pinheadmz
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK gmaxwell

2025-08-08

#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK storopoli
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK sipa
#33116
refactor: Convert uint256 to Txid
ACK kevkevinpal
#33116
refactor: Convert uint256 to Txid
ACK maflcko
#33155
contrib: drop `bitcoin-util` exception from FORTIFY check
Concept ACK hebasto

2025-08-07

#33125
ci: Use mlc `v1` and fix typos
ACK maflcko
#33151
subtree: update crc32c subtree
ACK maflcko

2025-08-06

#33144
build: Set AUTHOR_WARNING on warnings
ACK l0rinc
#33105
validation: detect witness stripping without re-running Script checks
Concept ACK sipa
#33126
Removing Bitcoin core text where unnecessary
Concept ACK bigshiny90

2025-08-05

#33122
test: remove duplicated code in test/functional/wallet_migration.py
Code Review ACK l0rinc
#33117
Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications
Concept ACK pinheadmz
#33133
rpc: fix getpeerinfo ping duration unit docs
ACK maflcko
#33133
rpc: fix getpeerinfo ping duration unit docs
utACK luke-jr
#33119
rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
utACK luke-jr
#33134
refactor, index: Remove member variables in coinstatsindex
Concept ACK Sammie05

2025-08-04

#33126
Removing Bitcoin core text where unnecessary
ACK BitcoinMechanic
#33126
Removing Bitcoin core text where unnecessary
Concept ACK luke-jr
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK jsarenik
#33121
test: fix p2p_leak_tx.py
Concept ACK jonatack
#33133
rpc: fix getpeerinfo ping duration unit docs
ACK maflcko
#33132
fuzz: txgraph: fix `real_is_optimal` flag propagation in `CommitStaging`
ACK sipa

2025-08-02

#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK petertodd
#33119
rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
ACK Sammie05

2025-08-01

#33118
test: fix anti-fee-sniping off-by-one error
ACK achow101
#33113
refactor: Use immediate lambda to work around GCC bug 117966
ACK achow101
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK darosior
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK ArmchairCryptologist

2025-07-31

#33105
validation: detect witness stripping without re-running Script checks
ACK achow101
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK aeonBTC
#33104
test: Perform backup filename checks in migrate_and_get_rpc in wallet_migration.py
reACK fjahr
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK w0xlt
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK caesrcd
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK jlopp
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK benthecarman
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK delta1

2025-07-30

#33102
fuzz: cover BanMan::IsDiscouraged
ACK maflcko