Looking for NACKs? → nackamoto.com

Last updated at 2025-11-30 20:04 UTC

2025-11-30

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK wiz

2025-11-28

#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
ACK fanquake
#33909
ci: Make the max number of commits tested explicit
ACK maflcko

2025-11-27

#33962
refactor: replace manual promise with SyncWithValidationInterfaceQueue
ACK maflcko
#33960
log: Use more severe log level (warn/err) where appropriate
Code Review ACK l0rinc
#33954
test: add functional test for outbound connection management
Concept ACK vasild
#33951
test: check for output to stdout in `TestShell` test
ACK maflcko
#33943
kernel: don't use assert to handle invalid user input
Concept ACK yuvicc

2025-11-26

#33950
guix: reduce allowed exported symbols
Concept ACK laanwj
#33946
interfaces: remove redundant mempool lock in ChainImpl::isInMempool()
utACK instagibbs
#33943
kernel: don't use assert to handle invalid user input
Concept ACK sedited
#33946
interfaces: remove redundant mempool lock in ChainImpl::isInMempool()
ACK maflcko
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
ACK maflcko
#33943
kernel: don't use assert to handle invalid user input
Concept ACK stringintech
#33891
kernel: Expose reusable `PrecomputedTransactionData` in script validation
Concept ACK sedited
#33914
Change Parse descriptor argument to string_view
ACK maflcko

2025-11-25

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK RandyMcMillan
#33906
depends: Add patch for Windows11Style plugin
ACK fanquake
#33623
doc: document capnproto and libmultiprocess deps in 29.x
Concept ACK fanquake
#33862
txgraph: drop move assignment operator
ACK instagibbs
#33862
txgraph: drop move assignment operator
reACK l0rinc
#33921
doc: clarify and cleanup macOS fuzzing notes
Concept ACK l0rinc
#33921
doc: clarify and cleanup macOS fuzzing notes
ACK frankomosh

2025-11-24

#33629
Cluster mempool
reACK glozow
#33893
test: add `-alertnotify` test for large work invalid chain warning
reACK brunoerg
#33932
ci: Use latest Xcode that the minimum macOS version allows
ACK l0rinc
#33854
fix assumevalid is ignored during reindex
Concept ACK l0rinc

2025-11-23

#33629
Cluster mempool
reACK instagibbs

2025-11-21

#33770
init: Require explicit -asmap filename
ACK achow101
#33770
init: Require explicit -asmap filename
ACK fjahr
#33915
test: Retry download in get_previous_releases.py
ACK achow101
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
ACK maflcko
#33858
test: add unit test coverage for the empty leaves path in MerkleComputation
ACK maflcko
#33629
Cluster mempool
ACK glozow

2025-11-20

#33917
clang-format: Set Bitcoin Core IncludeCategories
ACK l0rinc
#33915
test: Retry download in get_previous_releases.py
ACK davidgumberg
#33906
depends: Add patch for Windows11Style plugin
Concept ACK fanquake
#33918
depends: Update Qt download link
Concept ACK fanquake
#33880
test: Fix race condition in IPC interface block progation test
ACK maflcko
#33880
test: Fix race condition in IPC interface block progation test
utACK Sjors
#33896
clang-format: Set InsertNewlineAtEOF: true
ACK achow101
#33867
kernel: handle null or empty directories in implementation
ACK achow101

2025-11-19

#33636
wallet: Expand MuSig test coverage and follow-ups
Concept ACK achow101
#33893
test: add `-alertnotify` test for large work invalid chain warning
Concept ACK sedited
#33880
test: Fix race condition in IPC interface block progation test
utACK Sjors
#33867
kernel: handle null or empty directories in implementation
ACK maflcko
#33770
init: Require explicit -asmap filename
utACK vostrnad
#33856
kernel, validation: Refactor ProcessNewBlockHeaders to return BlockValidationState
Concept ACK exp3rimenter
#33770
init: Require explicit -asmap filename
reACK fjahr
#33770
init: Require explicit -asmap filename
reACK brunoerg
#33908
kernel: add context‑free block validation API (`btck_check_block_context_free`) with POW/Merkle flags
Concept ACK yuvicc
#33906
depends: Add patch for Windows11Style plugin
ACK waketraindev

2025-11-18

#33903
ci: Remove redundant busybox option
Concept ACK hebasto
#33888
ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG
ACK janb84
#33903
ci: Remove redundant busybox option
Concept ACK fanquake
#33887
doc: Improve CI docs on env and qemu-user-static
ACK maflcko
#33896
clang-format: Set InsertNewlineAtEOF: true
ACK l0rinc
#33891
kernel: Expose reusable `PrecomputedTransactionData` in script validation
Concept ACK yuvicc
#33819
mining: add getCoinbase()
ACK ajtowns
#33872
init: completely remove `-maxorphantx` option
ACK achow101

2025-11-17

#33870
refactor: remove incorrect lifetimebounds
ACK l0rinc
#33887
doc: Improve CI docs on env and qemu-user-static
Concept ACK waketraindev
#33872
init: completely remove `-maxorphantx` option
ACK maflcko
#33810
ci: Add IWYU job
Concept ACK stickies-v
#33869
refactor: Avoid -W*-whitespace in git archive
ACK fanquake
#33876
doc: Update NetBSD Build Guide
ACK fanquake
#33680
validation: do not wipe utxo cache for stats/scans/snapshots
utACK cedwies

2025-11-16

#33867
kernel: handle null or empty directories in implementation
ACK stringintech

2025-11-15

#33865
cmake: Specify Windows plugin path in `test_bitcoin-qt` property
ACK purpleKarrot

2025-11-14

#33770
init: Require explicit -asmap filename
ACK fjahr
#33847
kernel: Improve logging API
Concept ACK stickies-v
#33785
util: Allow `Assert` (et al.) in contexts without __func__
Concept ACK danielabrozzoni

2025-11-13

#33856
kernel, validation: Refactor ProcessNewBlockHeaders to return BlockValidationState
Concept ACK w0xlt
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK murchandamus
#33870
refactor: remove incorrect lifetimebounds
Concept ACK stickies-v
#33776
ci: Lint follow-ups
ACK m3dwards
#33855
kernel: add btck_block_tree_entry_equals
ACK maflcko
#33870
refactor: remove incorrect lifetimebounds
ACK maflcko
#33862
txgraph: drop move assignment operator
ACK ajtowns

2025-11-12

#33866
refactor: Let CCoinsViewCache::BatchWrite return void
Concept ACK l0rinc
#33864
scripted-diff: fix leftover references to `policy/fees.h`
ACK vicjuma
#33864
scripted-diff: fix leftover references to `policy/fees.h`
ACK kevkevinpal
#33858
test: add unit test coverage for the empty leaves path in MerkleComputation
ACK kevkevinpal
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK laanwj
#33774
cmake: Move IPC tests to `ipc/test`
ACK Sjors
#33853
kernel: Allow null arguments for serialized data
Code Review ACK yuvicc

2025-11-11

#33771
refactor: C++20 operators
utACK optout21
#33847
kernel: Improve logging API
Concept ACK sedited
#33819
mining: add getCoinbase()
Concept ACK optout21
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
Concept ACK fanquake
#33724
refactor: Return uint64_t from GetSerializeSize
Concept ACK laanwj

2025-11-10

#33701
test: add case where `TOTAL_TRIES` is exceeded yet solution remains
Code Review ACK frankomosh
#33805
merkle: migrate `path` arg to reference and drop unused args
utACK optout21
#33805
merkle: migrate `path` arg to reference and drop unused args
Concept ACK optout21
#33671
wallet: Add separate balance info for non-mempool wallet txs
Concept ACK RandyMcMillan
#33827
doc: Correct `pkgin` command usage on NetBSD
ACK fanquake
#33824
ci: Enable experimental kernel stuff in most CI tasks via `dev-mode`
Concept ACK stickies-v
#33826
scripted-diff: Remove obsolete comment
ACK maflcko

2025-11-08

#33826
scripted-diff: Remove obsolete comment
Code Review ACK l0rinc

2025-11-07

#33818
ci: Extend tidy job to cover kernel code
ACK maflcko

2025-11-06

#33724
refactor: Return uint64_t from GetSerializeSize
ACK l0rinc
#33786
script: remove dead code in `CountWitnessSigOps`
ACK maflcko
#33770
init: Require explicit -asmap filename
ACK jurraca
#33796
kernel: Expose `CheckTransaction` consensus validation function
Concept ACK sedited
#33793
test: move create_malleated_version() to messages.py for reuse
ACK l0rinc
#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
ACK purpleKarrot

2025-11-05

#33786
script: remove dead code in `CountWitnessSigOps`
ACK kevkevinpal
#33793
test: move create_malleated_version() to messages.py for reuse
ACK maflcko
#33791
kernel: Use enumeration type for flags argument
ACK alexanderwiederin
#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
ACK maflcko
#33789
doc: add cmake help option in Windows build docs
ACK waketraindev
#33768
refactor: remove dead branches in `SingletonClusterImpl`
ACK instagibbs
#33775
guix: use GCC 14.3.0 over 13.3.0
ACK maflcko

2025-11-04

#33779
ci, iwyu: Fix warnings in `src/kernel` and treat them as errors
Code Review ACK l0rinc
#33781
clang-tidy: Remove no longer needed NOLINT
ACK l0rinc
#33781
clang-tidy: Remove no longer needed NOLINT
ACK maflcko
#33780
guix: disable libsanitizer in Linux GCC build
ACK maflcko
#33778
depends: add zeromq patch to fix mingw CMake file install location
Concept ACK hebasto
#33714
random: scope environ extern to macOS, BSDs and Illumos
ACK l0rinc
#33626
ci: run native fuzz with MSAN job
ACK maflcko
#33775
guix: use GCC 14.3.0 over 13.3.0
Concept ACK hebasto
#33764
ci: Add Windows + UCRT jobs for cross-compiling and native testing
ACK maflcko
#33728
test: Add bitcoin-chainstate test for assumeutxo functionality
ACK frankomosh

2025-11-03

#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
utACK optout21
#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
utACK optout21
#33680
validation: do not wipe utxo cache for stats/scans/snapshots
utACK optout21
#33754
ci: gha: Set debug_pull_request_number_str annotation
Code Review ACK l0rinc
#33754
ci: gha: Set debug_pull_request_number_str annotation
ACK maflcko

2025-11-01

#33665
wallet: remove redundant sighash calculation in Musig2 signing flow
Concept ACK optout21
#33711
transaction: Adding script witness to ToString for CTxIn
Concept ACK optout21

2025-10-31

#33757
refactor: make script Solver's often-unused solutions parameter optional
Code Review ACK Raimo33
#33754
ci: gha: Set debug_pull_request_number_str annotation
ACK davidgumberg
#33753
test: Format strings in `test_runner`
ACK maflcko
#33738
log: avoid collecting `GetSerializeSize` data when compact block logging is disabled
Concept ACK 0xB10C
#33702
contrib: Remove brittle, confusing and redundant UTF8 encoding from Python IO
Concept ACK laanwj
#33676
interfaces: enable cancelling running `waitNext` calls
Concept ACK Sjors
#33753
test: Format strings in `test_runner`
ACK maflcko
#33746
ci: Add missing python3-dev package for riscv64
ACK fanquake

2025-10-30

#33746
ci: Add missing python3-dev package for riscv64
ACK fanquake
#33728
test: Add bitcoin-chainstate test for assumeutxo functionality
Concept ACK yuvicc
#33744
ci: Fix lint runner selection (and docker cache)
ACK maflcko
#33738
log: avoid collecting `GetSerializeSize` data when compact block logging is disabled
Concept ACK sedited

2025-10-29

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK delta1
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK l0rinc
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
reACK delta1

2025-10-28

#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK john-moffett
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK davidgumberg
#33724
refactor: Return uint64_t from GetSerializeSize
Concept ACK l0rinc
#33683
refactor/doc: Add blockman param to GetTransaction doc comment
reACK kevkevinpal
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK l0rinc
#33693
ci: use pycapnp 2.2.1
ACK maflcko
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK onyxcoyote
#33677
ci: Retry image building once on failure
Concept ACK davidgumberg
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK frodrik-froggo
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK gmaxwell
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK john-moffett
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK hsjoberg
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK niteshbalusu11
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK polespinasa
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK Symphonic3
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK jlopp
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK achow101
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
Concept ACK waketraindev
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK delta1
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
utACK reardencode
#33724
refactor: Return uint64_t from GetSerializeSize
Concept ACK darosior
#33723
chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
ACK dergoegge
#33676
interfaces: enable cancelling running `waitNext` calls
Code Review ACK furszy

2025-10-27

#33689
http: replace WorkQueue and single threads handling for ThreadPool
ACK sedited

2025-10-25

#33701
test: add case where `TOTAL_TRIES` is exceeded yet solution remains
Concept ACK alvroble

2025-10-24

#33683
refactor/doc: Add blockman param to GetTransaction doc comment
ACK l0rinc
#33677
ci: Retry image building once on failure
ACK kevkevinpal
#33677
ci: Retry image building once on failure
reACK l0rinc
#33674
ci: Doc ASLR workaround for sanitizer tasks
ACK Sjors
#33677
ci: Retry image building once on failure
Code Review ACK l0rinc
#33693
ci: use pycapnp 2.2.1
ACK maflcko

2025-10-23

#33689
http: replace WorkQueue and single threads handling for ThreadPool
Concept ACK pinheadmz
#33666
ci: Drop libFuzzer from msan fuzz task
Concept ACK dergoegge
#33674
ci: Doc ASLR workaround for sanitizer tasks
ACK fanquake
#33683
refactor/doc: Add blockman param to GetTransaction doc comment
ACK maflcko

2025-10-22

#33662
doc: add AGENTS.md
ACK kevkevinpal
#33679
test: set number of RPC server threads to 2
ACK kevkevinpal
#33679
test: set number of RPC server threads to 2
ACK l0rinc
#33679
test: set number of RPC server threads to 2
ACK maflcko
#33631
init: Split file path handling out of -asmap option
Concept ACK laanwj
#33639
ci: Only write docker build images to Cirrus cache
reACK cedwies
#33675
randomenv: drop self define of 'environ'
Concept ACK laanwj
#33665
wallet: remove redundant sighash calculation in Musig2 signing flow
Concept ACK Raimo33
#33639
ci: Only write docker build images to Cirrus cache
ACK m3dwards
#33670
test: Use unassigned p2p_port instead of hardcoded 60000 in p2p_i2p_ports.py
Code Review ACK laanwj

2025-10-21

#33669
Add libbitcoinkernel example files
Concept ACK sedited
#33666
ci: Drop libFuzzer from msan fuzz task
ACK kevkevinpal
#33657
rest: allow reading partial block data from storage
Concept ACK optout21
#33662
doc: add AGENTS.md
ACK maflcko

2025-10-20

#33661
test: Add test on skip heights in CBlockIndex
Concept ACK l0rinc
#33662
doc: add AGENTS.md
Concept ACK m3dwards
#33633
test: [move-only] binary utils to utils.py
ACK yuvicc

2025-10-17

#33637
refactor: optimize block index comparisons (1.4-6.8x faster)
ACK Raimo33

2025-10-16

#33641
Update leveldb subtree to latest master
ACK cedwies
#33633
test: [move-only] binary utils to utils.py
Concept ACK l0rinc
#33641
Update leveldb subtree to latest master
ACK l0rinc
#33613
[28.x] Backport & finalise 28.3
ACK marcofleon
#33633
test: [move-only] binary utils to utils.py
ACK Sjors

2025-10-15

#33633
test: [move-only] binary utils to utils.py
ACK kevkevinpal
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
ACK maflcko

2025-10-14

#33630
doc: correct topology requirements in submitpackage helptext
ACK kevkevinpal
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
Tested ACK l0rinc
#33626
ci: run native fuzz with MSAN job
Concept ACK dergoegge
#33624
test: P2SH sig ops are only counted with `SCRIPT_VERIFY_P2SH`
ACK maflcko
#33612
test: change log rate limit version gate
ACK maflcko
#33623
doc: document capnproto and libmultiprocess deps in 29.x
Concept ACK sipa

2025-10-13

#33612
test: change log rate limit version gate
ACK kevkevinpal