Looking for NACKs? → nackamoto.com

Last updated at 2026-01-15 00:08 UTC

2026-01-14

#34210
bench: Remove -priority-level= option
ACK achow101
#34186
test: use dynamic port allocation in proxy tests
ACK achow101
#34146
p2p: send first addr self-announcement in separate message 🎄
ACK achow101
#34185
test: fix `feature_pruning` when built without wallet
ACK achow101
#34036
contrib: update macOS SDK to Xcode-26.1.1-17B100
Concept ACK theuni
#34268
[29.x] backports + final changes for 29.3
ACK achow101
#34285
ci: Install `pyzmq` for functional tests on Windows
ACK maflcko
#34243
doc: validation: fix `PackageMempoolChecks` incorrect comment
ACK instagibbs
#34284
ipc, test: Add tests for unclean disconnect and thread busy behavior
Concept ACK ismaelsadeeq
#34285
ci: Install `pyzmq` for functional tests on Windows
ACK maflcko
#34243
doc: validation: fix `PackageMempoolChecks` incorrect comment
ACK yashbhutwala
#34100
doc: Use multipath descriptors in descriptors.md and linked test
ACK yashbhutwala
#34145
test: Add unit test for OP_NUMEQUALVERIFY
ACK yashbhutwala
#34282
qa: Fix Windows logging bug
ACK maflcko
#34269
wallet: disallow creating new or restoring to an unnamed (default) wallet
utACK Sjors
#34109
refactor: Use uint64_t over size_t for serialize corruption check in fees.dat
utACK luke-jr
#34272
psbt: Fix `PSBTInputSignedAndVerified` bounds `assert`
ACK achow101

2026-01-13

#34168
qa: Require `--exclude` for each excluded test
ACK achow101
#34099
test: Improve code coverage for pubkey checks
ACK maflcko
#34272
psbt: Fix `PSBTInputSignedAndVerified` bounds `assert`
ACK maflcko
#34272
psbt: Fix `PSBTInputSignedAndVerified` bounds `assert`
utACK optout21
#34210
bench: Remove -priority-level= option
Concept ACK fanquake
#34238
wallet: remove erroneous-on-reorg Assume()
ACK bensig

2026-01-12

#34266
release note: cpfp carveout removed in 31.0
ACK glozow
#34266
release note: cpfp carveout removed in 31.0
ACK l0rinc
#34259
Find minimal chunks in SFL
reACK instagibbs
#34256
test: support `get_bind_addrs` and `feature_bind_extra` on macOS
ACK bensig
#34254
validation: Prevent duplicate logging and looping in invalid block handling
ACK bensig
#34244
test: Prevent loop from running out of utxos in bip68 test
ACK bensig
#34260
contrib: Remove unused functions
ACK bensig
#34259
Find minimal chunks in SFL
reACK instagibbs
#34260
contrib: Remove unused functions
ACK fjahr

2026-01-11

#34165
coins: don't mutate main cache when connecting block
ACK l0rinc

2026-01-10

#34244
test: Prevent loop from running out of utxos in bip68 test
ACK maflcko
#34236
Add sedited to trusted-keys
ACK Sjors

2026-01-09

#34240
ci: Run feature_unsupported_utxo_db.py on Windows
ACK hebasto
#34181
refactor: [p2p] Make ProcessMessage private again, Use references when non-null
utACK optout21
#34236
Add sedited to trusted-keys
ACK polespinasa
#34227
guix: Fix `osslsigncode` tests
ACK fanquake
#34236
Add sedited to trusted-keys
ACK dergoegge
#34168
qa: Require `--exclude` for each excluded test
ACK maflcko

2026-01-08

#34226
wallet: test: Relative wallet failed migration cleanup
ACK achow101
#34236
Add sedited to trusted-keys
ACK fjahr
#34208
bench: add fluent API for untimed `setup` steps in nanobench
ACK bensig
#34161
refactor: Avoid UB from `std::distance` with `nullptr` in `PoolAllocator`
ACK bensig
#34236
Add sedited to trusted-keys
ACK achow101
#34236
Add sedited to trusted-keys
ACK w0xlt
#34236
Add sedited to trusted-keys
ACK instagibbs
#34162
net: Avoid undershooting in GetAddressesUnsafe
ACK bensig
#34236
Add sedited to trusted-keys
ACK janb84
#34224
init: Return EXIT_SUCCESS on interrupt
ACK maflcko
#34236
Add sedited to trusted-keys
ACK l0rinc
#34109
refactor: Use uint64_t over size_t for serialize corruption check in fees.dat
utACK ismaelsadeeq
#34225
refactor, key: move `CreateMuSig2{Nonce,PartialSig}` functions to `musig.{h,cpp}` module
Concept ACK rkrux
#34230
fuzz: Reject too large descriptor leaf sizes in scriptpubkeyman target
Concept ACK brunoerg
#34225
refactor, key: move `CreateMuSig2{Nonce,PartialSig}` functions to `musig.{h,cpp}` module
ACK w0xlt
#34226
wallet: test: Relative wallet failed migration cleanup
ACK w0xlt

2026-01-07

#34176
wallet: improve error msg when db directory is not writable
ACK bensig
#34170
fuzz: Extend `scriptpubkeyman` coverage
ACK bensig
#34224
init: Return EXIT_SUCCESS on interrupt
Concept ACK bensig
#34222
[29.x] Backport wallets directory deletion fixes
ACK bensig
#34223
[28.x] Backport wallets directory deletion fixes
ACK bensig
#34221
test: migration, avoid backup name mismatch in default_wallet_failure
ACK bensig
#34221
test: migration, avoid backup name mismatch in default_wallet_failure
ACK achow101
#34207
coins/refactor: enforce `GetCoin()` returns only unspent coins
ACK bensig
#34210
bench: Remove -priority-level= option
ACK bensig
#34213
net: do not read/dump anchors if network is not active
ACK bensig
#34209
[30.x]: Final backports & 30.2rc1
ACK darosior
#34215
wallettool: fix unnamed createfromdump failure walletsdir deletion
ACK waketraindev
#34213
net: do not read/dump anchors if network is not active
Concept ACK waketraindev

2026-01-06

#34135
rpc: [wallet] Use unsigned type for tx version in sendall
ACK achow101
#34214
policy: restore 80-byte default for datacarriersize
ACK frkrueger
#34156
wallet: fix unnamed legacy wallet migration failure
ACK achow101
#34001
test: fix test_limit_enforcement_package
ACK bensig
#34210
bench: Remove -priority-level= option
Concept ACK hebasto
#34085
cluster mempool: exploit SFL properties in txgraph
reACK instagibbs
#34204
test: fix intermittent failure in p2p_addr_selfannouncement
ACK maflcko
#34203
doc: p2p: replace last remaining "command" terminology with "message type"
ACK maflcko
#34156
wallet: fix unnamed legacy wallet migration failure
ACK achow101

2026-01-05

#34010
psbt: detect invalid MuSig2 pubkeys in deserialization
ACK theStack
#34197
rpc, net: deprecate `startingheight` field of `getpeerinfo` RPC
ACK achow101
#34010
psbt: detect invalid MuSig2 pubkeys in deserialization
ACK achow101
#34164
validation: add reusable coins view for ConnectBlock
ACK bensig
#34146
p2p: send first addr self-announcement in separate message 🎄
ACK bensig
#34142
policy: Check Taproot control block size correctly in `IsWitnessStandard`
ACK bensig
#34204
test: fix intermittent failure in p2p_addr_selfannouncement
ACK bensig
#34203
doc: p2p: replace last remaining "command" terminology with "message type"
ACK billymcbip
#34203
doc: p2p: replace last remaining "command" terminology with "message type"
ACK l0rinc
#34203
doc: p2p: replace last remaining "command" terminology with "message type"
ACK l0rinc
#34136
test: Allow mempool_updatefromblock.py to run on 32-bit
ACK instagibbs
#34156
wallet: fix unnamed legacy wallet migration failure
Concept ACK rkrux
#34010
psbt: detect invalid MuSig2 pubkeys in deserialization
utACK fjahr
#34156
wallet: fix unnamed legacy wallet migration failure
ACK willcl-ark
#34132
refactor: inline `CCoinsViewErrorCatcher` into `CCoinsViewDB`
Concept ACK sedited
#34186
test: use dynamic port allocation in proxy tests
Concept ACK theStack
#34176
wallet: improve error msg when db directory is not writable
Concept ACK stickies-v
#34135
rpc: [wallet] Use unsigned type for tx version in sendall
ACK bensig
#34109
refactor: Use uint64_t over size_t for serialize corruption check in fees.dat
ACK bensig
#34156
wallet: fix unnamed legacy wallet migration failure
ACK achow101
#34198
wallet: fix ancient wallets migration
Code Review ACK bensig

2026-01-04

#34090
net: Fix `-Wmissing-braces`
ACK bensig

2026-01-03

#34181
refactor: [p2p] Make ProcessMessage private again, Use references when non-null
ACK bensig
#34154
test: Enable ruff E713 lint
ACK l0rinc
#34154
test: Enable ruff E713 lint
ACK bensig
#34184
mining: add cooldown to createNewBlock() immediately after IBD
ACK bensig

2026-01-02

#34168
qa: Require `--exclude` for each excluded test
Tested ACK l0rinc
#34156
wallet: fix unnamed legacy wallet migration failure
ACK achow101
#34136
test: Allow mempool_updatefromblock.py to run on 32-bit
ACK bensig
#34179
refactor: Enable transparent lookup for setBlockIndexCandidates to remove const_cast
ACK bensig
#34191
doc: archive release notes for v30.1
ACK marcofleon
#34188
test: Add multiple transactions and error handling tests for getreceivedbyaddress
ACK bensig

2026-01-01

#34168
qa: Require `--exclude` for each excluded test
ACK maflcko
#34168
qa: Require `--exclude` for each excluded test
ACK bensig
#34174
doc: update copyright year to 2026
ACK Sjors

2025-12-31

#34185
test: fix `feature_pruning` when built without wallet
ACK bensig
#34145
test: Add unit test for OP_NUMEQUALVERIFY
ACK bensig
#34186
test: use dynamic port allocation in proxy tests
ACK bensig
#34183
doc: fix double-word typos in comments
ACK maflcko

2025-12-30

#34182
doc: Update OpenBSD Build Guide
ACK katesalazar
#34183
doc: fix double-word typos in comments
ACK l0rinc
#34085
cluster mempool: exploit SFL properties in txgraph
reACK instagibbs
#34174
doc: update copyright year to 2026
ACK fjahr
#34169
fuzz: change fuzz runner test_runner.py to be cwd independent
ACK maflcko
#34102
depends: capnp 1.3.0
ACK Sjors

2025-12-29

#34172
Fix intermittent issue in p2p_1p1c_network.py
utACK glozow
#34162
net: Avoid undershooting in GetAddressesUnsafe
Code Review ACK Bicaru20

2025-12-28

#34158
torcontrol: Remove libevent usage
Concept ACK waketraindev

2025-12-27

#34149
test: add comprehensive bech32 unit tests based on BIP-173 :christmas_tree:
Concept ACK billymcbip
#34158
torcontrol: Remove libevent usage
Concept ACK pablomartin4btc
#34158
torcontrol: Remove libevent usage
Concept ACK pinheadmz
#34158
torcontrol: Remove libevent usage
Concept ACK sedited
#34145
test: Add unit test for OP_NUMEQUALVERIFY
ACK billymcbip

2025-12-25

#34054
net processing: Add ibd check before processing block for txdownloadman
Concept ACK fjahr
#34119
contrib: remove `copyright_header.py`
ACK fjahr
#34147
scripted-diff: refactor: wallet: Delete duplicate IsCrypted()
utACK billymcbip
#34147
scripted-diff: refactor: wallet: Delete duplicate IsCrypted()
ACK maflcko

2025-12-24

#34116
cmake: Fix debugging info
Concept ACK arejula27
#34081
build: Fix source paths for debugging in CMake
Concept ACK ismaelsadeeq
#34137
test: Avoid hard time.sleep(1) in feature_init.py
utACK Sjors

2025-12-23

#34010
psbt: detect invalid MuSig2 pubkeys in deserialization
ACK achow101
#34098
test: [move-only] Move lint functions into modules
Concept ACK rkrux

2025-12-22

#34039
test: address self-announcement
ACK achow101
#34081
build: Fix source paths for debugging in CMake
Concept ACK pinheadmz
#34037
wallet, doc: clarify the coin selection filters that enforce cluster count
Concept ACK ismaelsadeeq

2025-12-20

#34124
refactor: make `CCoinsView` a purely virtual abstract base class
Concept ACK andrewtoth

2025-12-18

#34107
build: Update minimum required Boost version
ACK maflcko
#34039
test: address self-announcement
ACK Bicaru20
#34105
kernel: revert accidentally removed copyright header
ACK fanquake
#34025
net: Waste less time in socket handling
ACK theuni
#34084
scripted-diff: [doc] Unify stale copyright headers
ACK l0rinc
#34102
depends: capnp 1.3.0
Concept ACK hebasto
#34095
refactor: enable `readability-container-contains` clang-tidy rule
ACK Chand-ra
#34094
ci: bump actions/checkout version to v6
ACK fanquake
#34088
log: Use `__func__` for -logsourcelocations
ACK stickies-v
#34088
log: Use `__func__` for -logsourcelocations
ACK ajtowns

2025-12-17

#34092
[30.x] Finalise v30.1
ACK waketraindev
#34091
fuzz: doc: remove any mention to `address_deserialize_v2`
ACK maflcko
#34088
log: Use `__func__` for -logsourcelocations
Concept ACK 0xB10C
#34088
log: Use `__func__` for -logsourcelocations
Concept ACK Crypt-iQ

2025-12-16

#34074
A few followups after introducing `/rest/blockpart/` endpoint
ACK l0rinc
#34074
A few followups after introducing `/rest/blockpart/` endpoint
ACK maflcko
#34060
test: fix race condition in p2p_v2_misbehaving.py peerid assertion
ACK maflcko

2025-12-15

#34074
A few followups after introducing `/rest/blockpart/` endpoint
reACK l0rinc
#34079
kernel: Remove non-kernel module includes
Concept ACK hebasto
#34077
refactor: Use an enum for `Autofile::seek` wrapper
Concept ACK l0rinc
#34074
A few followups after introducing `/rest/blockpart/` endpoint
ACK maflcko
#34063
Make `transaction_indentifier` hex string constructor evaluated at comptime
ACK maflcko

2025-12-14

#34074
A few followups after introducing `/rest/blockpart/` endpoint
Code Review ACK l0rinc

2025-12-13

#34063
Make `transaction_indentifier` hex string constructor evaluated at comptime
ACK l0rinc
#34051
log: Remove brittle and confusing LogPrintLevel
ACK ajtowns
#34022
validation: Remove min_pow_checked arg in ProcessNewBlockHeaders
ACK yuvicc

2025-12-12

#34059
refactor: Use NodeClock::time_point for m_addr_token_timestamp
ACK ajtowns
#34061
fuzz: Fix bugs in `clusterlin_postlinearize_tree` target
ACK sipa
#34057
test: add tests for cluster chunks
Concept ACK sipa
#34053
lint: Remove confusing, redundant, and brittle lint-spelling
Concept ACK stickies-v
#34053
lint: Remove confusing, redundant, and brittle lint-spelling
Concept ACK sedited
#34053
lint: Remove confusing, redundant, and brittle lint-spelling
ACK l0rinc

2025-12-11

#34050
fuzz: exercise `ComputeMerkleRoot` without `mutated` parameter
ACK frankomosh
#34045
test: Log IP of download server in get_previous_releases.py
utACK fjahr
#34046
bench: run `FindByte` across block-sized buffer
ACK Raimo33
#34046
bench: run `FindByte` across block-sized buffer
ACK maflcko
#34046
bench: run `FindByte` across block-sized buffer
Code Review ACK Raimo33

2025-12-10

#34044
streams: replace `std::find` with `memchr` (5x improvement)
Concept ACK Ataraxia009
#34039
test: address self-announcement
Code Review ACK Bicaru20
#34040
test: Detect truncated download in get_previous_releases.py
utACK Sjors
#34040
test: Detect truncated download in get_previous_releases.py
Concept ACK Sjors
#34025
net: Waste less time in socket handling
ACK maflcko
#34033
scripted-diff: Unify error and warning log formatting
ACK ajtowns

2025-12-09

#34025
net: Waste less time in socket handling
Concept ACK maflcko
#33986
doc: improvements to doc/descriptors.md
Concept ACK Sjors
#34008
log: don't rate-limit "new peer" with -debug=net
ACK maflcko
#34003
test: interface_ipc.py minor fixes and cleanup
ACK Sjors
#34008
log: don't rate-limit "new peer" with -debug=net
utACK stickies-v
#34026
fuzz: Add tests for `CCoinControl` methods
Code Review ACK l0rinc
#34003
test: interface_ipc.py minor fixes and cleanup
ACK Sjors

2025-12-08

#34022
validation: Remove min_pow_checked arg in ProcessNewBlockHeaders
reACK l0rinc

2025-12-07

#34022
validation: Remove min_pow_checked arg in ProcessNewBlockHeaders
Concept ACK yuvicc

2025-12-06

#34025
net: Waste less time in socket handling
Concept ACK sedited
#34003
test: interface_ipc.py minor fixes and cleanup
Concept ACK mercie-ux
#34017
fuzz: Add a test case for `ParseByteUnits()`
ACK maflcko

2025-12-05

#33995
depends: Propagate native C compiler to `sqlite` package
ACK fanquake

2025-12-04

#34006
Add util::Expected (std::expected)
Concept ACK ryanofsky
#34006
Add util::Expected (std::expected)
Concept ACK Sjors
#34006
Add util::Expected (std::expected)
Concept ACK sedited

2025-12-03

#33995
depends: Propagate native C compiler to `sqlite` package
Concept ACK fanquake

2025-12-02

#33985
fuzz: gate mempool entry based on weight
ACK sdaftuar
#33960
log: Use more severe log level (warn/err) where appropriate
ACK stickies-v

2025-12-01

#33966
refactor: disentangle miner startup defaults from runtime options
Concept ACK ryanofsky
#33965
mining: fix -blockreservedweight shadows IPC option
Concept ACK ryanofsky
#33972
cmake: Make `BUILD_KERNEL_TEST` depend on `BUILD_KERNEL_LIB`
ACK maflcko
#33971
cmake: Set `WITH_ZMQ` to `ON` in Windows presets
ACK maflcko
#33975
depends, doc: Add `tcl` as build dependency for `sqlite` package
ACK maflcko

2025-11-27

#33962
refactor: replace manual promise with SyncWithValidationInterfaceQueue
ACK maflcko
#33960
log: Use more severe log level (warn/err) where appropriate
Code Review ACK l0rinc