Looking for NACKs? → nackamoto.com

Last updated at 2025-08-05 14:07 UTC

2025-08-05

#33133
rpc: fix getpeerinfo ping duration unit docs
ACK maflcko
#33133
rpc: fix getpeerinfo ping duration unit docs
utACK luke-jr
#33119
rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
utACK luke-jr
#33134
refactor, index: Remove member variables in coinstatsindex
Concept ACK Sammie05

2025-08-04

#33126
Removing Bitcoin core text where unnecessary
ACK BitcoinMechanic
#33126
Removing Bitcoin core text where unnecessary
Concept ACK luke-jr
#32941
p2p: TxOrphanage revamp cleanups
ACK theStack
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
ACK jsarenik
#33121
test: fix p2p_leak_tx.py
Concept ACK jonatack
#32941
p2p: TxOrphanage revamp cleanups
ACK marcofleon
#32941
p2p: TxOrphanage revamp cleanups
utACK sipa
#33133
rpc: fix getpeerinfo ping duration unit docs
ACK maflcko
#33132
fuzz: txgraph: fix `real_is_optimal` flag propagation in `CommitStaging`
ACK sipa

2025-08-02

#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK petertodd
#33119
rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
ACK Sammie05

2025-08-01

#33118
test: fix anti-fee-sniping off-by-one error
ACK achow101
#33113
refactor: Use immediate lambda to work around GCC bug 117966
ACK achow101
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK darosior
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK ArmchairCryptologist

2025-07-31

#33093
refactor: remove unused `ser_writedata16be` and `ser_readdata16be`
ACK achow101
#33105
validation: detect witness stripping early on
ACK achow101
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK aeonBTC
#33104
test: Perform backup filename checks in migrate_and_get_rpc in wallet_migration.py
reACK fjahr
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK w0xlt
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK caesrcd
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK jlopp
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK benthecarman
#33106
policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
Concept ACK delta1
#33042
refactor: inline constant return values from `dbwrapper` write methods
Concept ACK TheCharlatan
#32998
Bump SCRIPT_VERIFY flags to 64 bit
Concept ACK darosior
#33093
refactor: remove unused `ser_writedata16be` and `ser_readdata16be`
ACK maflcko

2025-07-30

#33060
test: Slay BnB Mutants
ACK achow101
#33005
refactor: GenTxid type safety followups
ACK maflcko
#33100
ci: remove `ninja-build` from MSAN jobs
ACK maflcko
#33102
fuzz: cover BanMan::IsDiscouraged
ACK maflcko
#33083
qa: test that we do not disconnect a peer for submitting an invalid compact block
ACK kevkevinpal

2025-07-29

#32866
doc: add note for watch-only wallet migration
ACK achow101
#33075
doc: Add legacy wallet removal release notes
ACK achow101
#32959
Reduce minrelaytxfee to 100 sats/kvB
Concept ACK sipa
#33088
doc: move `cmake -B build -LH` up in Unix build docs
ACK maflcko
#33086
contrib: [tracing] fix pointer argument handling in mempool_monitor.py
Tested ACK 0xB10C

2025-07-28

#32973
validation: docs and cleanups for MemPoolAccept coins views
utACK sdaftuar
#33075
doc: Add legacy wallet removal release notes
ACK glozow
#33005
refactor: GenTxid type safety followups
ACK glozow
#32941
p2p: TxOrphanage revamp cleanups
Concept ACK theStack
#33011
log: rate limiting followups
Concept ACK l0rinc
#32866
doc: add note for watch-only wallet migration
reACK brunoerg
#32977
wallet: Remove wallet version and several legacy related functions
ACK maflcko
#33065
rpc, wallet: replace remaining hardcoded output types with `FormatAllOutputTypes`
ACK maflcko
#33064
test: fix RPC coverage check
ACK maflcko

2025-07-27

#33067
test: refactor mempool_accept_wtxid
ACK yuvicc

2025-07-26

#33000
ci: Run unit tests parallel with functional tests
Concept ACK fanquake
#33063
util: Revert "common: Close non-std fds before exec in RunCommandJSON"
ACK fanquake
#33069
[POC] wallet: Add Support for BIP-353 DNS-Based Bitcoin Address via External Resolver
Concept ACK Sjors
#33000
ci: Run unit tests parallel with functional tests
Concept ACK l0rinc
#32967
log: [refactor] Use info level for init logs
ACK l0rinc

2025-07-25

#33066
p2p: never check tx rejections by txid
Concept ACK darosior
#32997
index: Deduplicate HashKey / HeightKey handling
utACK fjahr
#32944
wallet: Remove `upgradewallet` RPC
ACK achow101
#32845
rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs
ACK achow101
#33056
[29.x] final changes for v29.1rc1
ACK fanquake
#33063
util: Revert "common: Close non-std fds before exec in RunCommandJSON"
Concept ACK darosior
#33063
util: Revert "common: Close non-std fds before exec in RunCommandJSON"
Concept ACK Sjors
#33063
util: Revert "common: Close non-std fds before exec in RunCommandJSON"
ACK fanquake
#33060
test: Slay BnB Mutants
Concept ACK yancyribbens
#32967
log: [refactor] Use info level for init logs
ACK fanquake
#33056
[29.x] final changes for v29.1rc1
ACK marcofleon
#33051
Don't fix Python patch version
ACK maflcko
#32945
tests: speed up coins_tests by parallelizing
ACK willcl-ark
#32944
wallet: Remove `upgradewallet` RPC
ACK maflcko

2025-07-24

#33060
test: Slay BnB Mutants
Concept ACK w0xlt
#33013
[29.x] Backport #32521
reACK marcofleon
#33004
Enable `-natpmp` by default
ACK laanwj
#33040
doc: update headers and remove manual TOCs
ACK maflcko
#33047
test: check proper OP_2ROT behavior
ACK maflcko

2025-07-23

#33034
wallet: Store transactions in a separate sqlite table
Concept ACK w0xlt
#32878
index: fix wrong assert of current_tip == m_best_block_index
ACK furszy
#33048
test: reduce runtime of p2p_opportunistic_1p1c.py
ACK achow101
#33040
doc: update headers and remove manual TOCs
ACK yuvicc
#33040
doc: update headers and remove manual TOCs
ACK maflcko
#32994
p2p: rename GetAddresses -> GetAddressesUnsafe
ACK luisschwab
#33004
Enable `-natpmp` by default
ACK ajtowns

2025-07-22

#32990
wallet: remove outdated `pszSkip` arg of database `Rewrite` func
ACK achow101
#32987
init: [gui] Avoid UB/crash in InitAndLoadChainstate
ACK achow101
#33004
Enable `-natpmp` by default
utACK sipa
#33020
test: delete commented-out tests and add a test case in wallet_signer
ACK achow101
#33004
Enable `-natpmp` by default
Concept ACK achow101
#33032
wallet, test: Replace MockableDatabase with in-memory SQLiteDatabase
utACK PeterWrighten
#32945
tests: speed up coins_tests by parallelizing
ACK achow101
#32994
p2p: rename GetAddresses -> GetAddressesUnsafe
ACK l0rinc
#33030
test: check tx is final when there is no locktime
ACK achow101
#33030
test: check tx is final when there is no locktime
ACK enirox001
#33020
test: delete commented-out tests and add a test case in wallet_signer
ACK Sjors
#33030
test: check tx is final when there is no locktime
ACK maflcko
#33037
doc: Add release notes for 32521 (MAX_TX_LEGACY_SIGOPS)
ACK darosior
#33037
doc: Add release notes for 32521 (MAX_TX_LEGACY_SIGOPS)
ACK Sjors
#32945
tests: speed up coins_tests by parallelizing
ACK maflcko
#32945
tests: speed up coins_tests by parallelizing
reACK l0rinc

2025-07-21

#32945
tests: speed up coins_tests by parallelizing
ACK l0rinc
#32827
mempool: Avoid needless vtx iteration during IBD
ACK glozow
#32945
tests: speed up coins_tests by parallelizing
ACK maflcko

2025-07-20

#32827
mempool: Avoid needless vtx iteration during IBD
ACK optout21

2025-07-18

#32999
ci: Use APT_LLVM_V in msan task
ACK m3dwards
#32822
fuzz: Make process_message(s) more deterministic
reACK marcofleon
#33007
test: fix `ReadTopologicalSet` unsigned integer overflow
ACK maflcko
#33007
test: fix `ReadTopologicalSet` unsigned integer overflow
utACK sipa
#32945
tests: speed up coins_tests by parallelizing
Concept ACK willcl-ark
#32989
ci: Migrate CI to hosted Cirrus Runners
Concept ACK 0xB10C
#33003
test: add option to skip large re-org test in feature_block
ACK maflcko

2025-07-17

#32994
p2p: rename GetAddresses -> GetAddressesUnsafe
Concept ACK brunoerg
#32987
init: [gui] Avoid UB/crash in InitAndLoadChainstate
Concept ACK hebasto
#32973
validation: docs and cleanups for MemPoolAccept coins views
reACK instagibbs
#32997
index: Deduplicate HashKey / HeightKey handling
Concept ACK fjahr
#32868
test: refactor: overhaul block hash determination for `CBlock{,Header}` objects
ACK maflcko

2025-07-16

#32984
wallet: Set migrated wallet name only on success
ACK davidgumberg
#32989
ci: Migrate CI to hosted Cirrus Runners
Concept ACK achow101

2025-07-15

#32922
test: use notarized v28.2 binaries and fix macOS detection
ACK maflcko

2025-07-14

#32922
test: use notarized v28.2 binaries and fix macOS detection
ACK m3dwards
#32948
refactor: cleanup index logging
ACK maflcko
#32968
test: fix intermittent failure in rpc_invalidateblock.py
ACK maflcko
#32943
depends: Force `CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE`
ACK fanquake
#32968
test: fix intermittent failure in rpc_invalidateblock.py
ACK maflcko
#32961
fix spelling in tor.md docs
ACK willcl-ark
#32959
Reduce minrelaytxfee to 100 sats/kvB
Concept ACK delta1
#32867
doc: mention key removal in rpc interface modification
ACK maflcko
#32961
fix spelling in tor.md docs
ACK maflcko

2025-07-12

#32945
tests: speed up coins_tests by parallelizing
ACK l0rinc
#32948
refactor: cleanup index logging
Code Review ACK l0rinc

2025-07-11

#32894
FUZZ: Test that BnB finds best solution
Concept ACK yancyribbens
#32950
validation: remove BLOCK_FAILED_CHILD
Concept ACK TheCharlatan
#32937
Enable `-Werror=dev` in CI & Guix
ACK Sjors
#32930
Resolve guix non-determinism with emplace_back instead of push_back
ACK maflcko
#32930
Resolve guix non-determinism with emplace_back instead of push_back
utACK Sjors

2025-07-10

#32943
depends: Force `CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE`
Concept ACK theuni
#32921
test: less ambiguous error if bitcoind is missing
ACK achow101
#32930
Resolve guix non-determinism with emplace_back instead of push_back
Code Review ACK l0rinc
#32937
Enable `-Werror=dev` in CI & Guix
Concept ACK hebasto
#32930
Resolve guix non-determinism with emplace_back instead of push_back
Concept ACK Sjors
#32930
Resolve guix non-determinism with emplace_back instead of push_back
ACK maflcko

2025-07-09

#32827
mempool: Avoid needless vtx iteration during IBD
ACK maflcko
#32845
rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs
ACK maflcko

2025-07-08

#32881
test: Turn rpcauth.py test into functional test
ACK l0rinc
#32895
wallet: Prepare for future upgrades by recording versions of last client to open and decrypt
Concept ACK ryanofsky
#32884
rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF`
ACK maflcko
#32893
doc: fix `BlockConnected` incorrect comment
ACK maflcko
#32862
rpc: use CScheduler for relocking wallet and remove RPCTimer
ACK achow101
#32835
test: fix feature_init.py intermittencies
ACK achow101

2025-07-07

#32893
doc: fix `BlockConnected` incorrect comment
ACK l0rinc
#32835
test: fix feature_init.py intermittencies
ACK maflcko

2025-07-05

#32862
rpc: use CScheduler for relocking wallet and remove RPCTimer
Code Review ACK fjahr

2025-07-03

#32822
fuzz: Make process_message(s) more deterministic
reACK marcofleon
#32865
cmake: Use `AUTHOR_WARNING` for warnings
ACK purpleKarrot
#32835
test: fix feature_init.py intermittencies
Concept ACK theStack
#32869
p2p: Relax BlockRequestAllowed to respond to advertised blocks
Concept ACK dergoegge
#32858
doc: Add workaround for vcpkg issue with paths with embedded spaces
ACK sipsorcery

2025-07-02

#32859
functional test: correctly detect nonstd TRUC tx vsize in feature_taproot
ACK achow101
#32859
functional test: correctly detect nonstd TRUC tx vsize in feature_taproot
utACK davidgumberg
#32835
test: fix feature_init.py intermittencies
Concept ACK hodlinator
#32823
test: Fix wait_for_getheaders() call in test_outbound_eviction_blocks_relay_only()
ACK achow101
#32837
depends: fix libevent `_WIN32_WINNT` usage
ACK hebasto
#32841
feature_taproot: sample tx version border values more
ACK maflcko

2025-07-01

#32846
doc: clarify that the "-j N" goes after the "--build build" part
ACK achow101
#32844
RPC/txoutproof: Support including (and verifying) proofs of wtxid
Concept ACK Sjors
#32828
build, docs: Fix Boost-related issues on NetBSD
ACK purpleKarrot
#32846
doc: clarify that the "-j N" goes after the "--build build" part
Concept ACK stickies-v
#32846
doc: clarify that the "-j N" goes after the "--build build" part
ACK maflcko
#32842
doc: add `/spenttxouts` to REST-interface.md
ACK maflcko

2025-06-30

#32835
test: fix feature_init.py intermittencies
ACK TheCharlatan
#32825
rest: rename `strURIPart` to `uri_part`
ACK maflcko
#32826
p2p: add more bad ports
utACK Sjors
#32833
test: Add `msgtype` to `msg_generic` slots
ACK maflcko

2025-06-29

#32826
p2p: add more bad ports
ACK kevkevinpal
#32821
rpc: Handle -named argument parsing where '=' character is used
Concept ACK yuvicc

2025-06-28

#32825
rest: rename `strURIPart` to `uri_part`
reACK l0rinc

2025-06-27

#32821
rpc: Handle -named argument parsing where '=' character is used
Concept ACK ryanofsky

2025-06-26

#32816
contrib: correct variable name in p2p_monitor.py
ACK maflcko
#32814
cmake: Explicitly specify `Boost_ROOT` for Homebrew's package
ACK purpleKarrot
#32810
[29.x] More backports
ACK josibake

2025-06-25

#32805
cmake: Use `HINTS` instead of `PATHS` in `find_*` commands
utACK purpleKarrot

2025-06-24

#32798
build: add root dir to CMAKE_PREFIX_PATH in toolchain
reACK josibake