Looking for NACKs? → nackamoto.com

Last updated at 2026-07-16 13:23 UTC

2026-07-16

#35729
refactor: test: Unroll `&&` conditions in macros
ACK maflcko
#35735
Add state to HTTPRequest
Concept ACK brunoerg
#35730
http: limit connected HTTPRemoteClients
Concept ACK stickies-v
#35728
rpc: Properly throw on internal I/O errors in GetTransaction
Concept ACK yuvicc
#35516
rpc: preserve global xpubs and proprietary fields in joinpsbts
ACK g-maxxx

2026-07-15

#35714
validation: stop writes after flush failure
ACK arejula27
#35730
http: limit connected HTTPRemoteClients
Concept ACK fjahr
#35590
test: wallet: BnB incomplete result on attempt-limit success
Concept ACK yancyribbens

2026-07-14

#35716
wallet: Replace mapWallet and wtxOrdered with a boost::multi_index
Concept ACK theuni
#35639
external_signer: validate fingerprint from enumerate response
ACK achow101
#35572
coins: make cursor iteration DB-only
ACK achow101
#35723
fuzz: Drop unnecessary mutexes
Code Review ACK l0rinc
#35723
fuzz: Drop unnecessary mutexes
ACK nervana21
#35723
fuzz: Drop unnecessary mutexes
ACK maflcko
#35680
private broadcast: bound memory use of broadcast attempts
Concept ACK optout21
#35681
test: cover disconnect on private broadcast peer with relay=false
ACK Herb-ops
#35719
ci: disable Qt build in OpenBSD cross job
ACK maflcko
#35712
mining: add getInfo() IPC method
Concept ACK w0xlt
#35699
[31.x] More Backports
ACK optout21

2026-07-13

#35714
validation: stop writes after flush failure
Concept ACK arejula27
#35713
Remove boost as a unit test runner
Concept ACK josibake
#35707
wallet: Make SQLiteDatabase::m_file_path an std::optional<fs::path>
Concept ACK Sjors

2026-07-12

#35696
i2p: update leaseset encryption types
ACK kevkevinpal
#35698
doc: Update enum class constant naming style guide
ACK kevkevinpal

2026-07-11

#35701
test: Remove `mock_process.cpp`
ACK maflcko
#35701
test: Remove `mock_process.cpp`
ACK kevkevinpal

2026-07-10

#35690
wallet: Introduce WalletError with machine-readable error code
ACK davidgumberg
#35690
wallet: Introduce WalletError with machine-readable error code
ACK achow101
#35578
net: don’t self advertise tor exit node ip addresses in outbound connections
Concept ACK naiyoma
#35701
test: Remove `mock_process.cpp`
Concept ACK hebasto
#35695
Remove myself as security contact
ACK fanquake
#35691
chainparams: delete my DNS seed
ACK Sjors

2026-07-09

#35690
wallet: Introduce WalletError with machine-readable error code
ACK davidgumberg
#35695
Remove myself as security contact
ACK achow101
#35691
chainparams: delete my DNS seed
ACK l0rinc
#35691
chainparams: delete my DNS seed
Concept ACK pinheadmz
#35655
wallet: Use in-memory SQLite for temporary wallet in exportwatchonlywallet
ACK achow101
#35691
chainparams: delete my DNS seed
ACK Sjors
#35570
refactor: Change some validation.cpp methods to return BlockValidationState
Concept ACK nervana21
#35689
test: Inline incorrect check in `util_tests`
ACK maflcko
#35655
wallet: Use in-memory SQLite for temporary wallet in exportwatchonlywallet
utACK Sjors
#35687
doc: fix v31.1 LevelDB PR link
ACK maflcko
#35616
refactor: Use u64 over size_t for all cache sizes to fix a 32-bit overflow
ACK l0rinc

2026-07-08

#35641
kernel: Add script evaluation tracer
Concept ACK theStack
#35673
refactor: Move LoadGenesisBlock to ChainstateManager
ACK stickies-v

2026-07-07

#35676
util: Abort in CheckDiskSpace/FlatFileSeq::Open on rare exceptions
Concept ACK l0rinc
#35673
refactor: Move LoadGenesisBlock to ChainstateManager
Tested ACK l0rinc
#35633
wallet: avoid call bumpfeediscount with negative values
ACK achow101
#35678
private broadcast: define and use new RPC_LIMIT_EXCEEDED error code ( + other follow-ups)
ACK instagibbs
#35675
mining: add block template manager
Concept ACK Sjors
#35676
util: Abort in CheckDiskSpace/FlatFileSeq::Open on rare exceptions
Concept ACK furszy
#35671
mining: add TxCollection to bandwidth-efficiently validate external block templates
Concept ACK ismaelsadeeq
#35655
wallet: Use in-memory SQLite for temporary wallet in exportwatchonlywallet
ACK pablomartin4btc

2026-07-06

#35579
wallet: reserve walletrescan before checking wallet is at the tip
ACK achow101
#35652
init: fix reindex deadlock by waking cv after interrupt
Code Review ACK l0rinc
#35661
Update libmultiprocess subtree to add `ThreadMap.makePool` method
ACK fanquake
#35652
init: fix reindex deadlock by waking cv after interrupt
ACK maflcko
#35658
refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>`
ACK maflcko
#35659
Clarify supported *BSD releases and drop outdated workarounds
ACK maflcko

2026-07-04

#35639
external_signer: validate fingerprint from enumerate response
utACK Sjors
#35568
txospenderindex: disable bloom filters to optimize disk usage
ACK l0rinc
#35655
wallet: Use in-memory SQLite for temporary wallet in exportwatchonlywallet
Concept ACK Sjors
#35634
txospenderindex: use zero-byte entry values
ACK fjahr

2026-07-03

#35464
kernel: Add function for creating chainparams with a signet challenge
ACK yuvicc
#35464
kernel: Add function for creating chainparams with a signet challenge
Concept ACK yuvicc
#35587
Remove boost as a unit test runner
Concept ACK optout21

2026-07-02

#35641
kernel: Add script evaluation tracer
Concept ACK w0xlt
#35641
kernel: Add script evaluation tracer
Concept ACK furszy
#35638
cmpctblock: refactor: Delete unnecessary code in `PartiallyDownloadedBlock::InitData()`
Concept ACK w0xlt

2026-07-01

#35464
kernel: Add function for creating chainparams with a signet challenge
ACK stickies-v
#35464
kernel: Add function for creating chainparams with a signet challenge
reACK edilmedeiros

2026-06-30

#35570
refactor: Change some validation.cpp methods to return BlockValidationState
Concept ACK yuvicc
#35624
test: cover addnode connection limit
Concept ACK sedited
#35621
validation: Ignore eventual error message from flushing in AcceptBlock
Concept ACK sedited
#35615
fuzz: restore CreateSock in PCP targets
ACK marcofleon
#35597
logging: More fully remove libevent log category
Code Review ACK l0rinc

2026-06-29

#35617
cli: Fix multisig error message spacing
ACK maflcko
#35569
Encapsulation for CTransaction
reACK josibake
#35609
ci: Bump tsan config to ubuntu:26.04 with -U_FORTIFY_SOURCE
ACK fanquake

2026-06-28

#35616
refactor: Use u64 over size_t for all cache sizes to fix a 32-bit overflow
Concept ACK fjahr

2026-06-27

#35604
log: expose `-logratelimit` in normal help
Concept ACK sipa
#35588
scripted-diff: Rename `Sock::{RECV,SEND,ERR}`
ACK maflcko
#35588
scripted-diff: Rename `Sock::{RECV,SEND,ERR}`
ACK maflcko
#35536
fuzz: share a single mocked steady clock across FuzzedSock instances
ACK HowHsu
#35588
scripted-diff: Rename `Sock::{RECV,SEND,ERR}`
reACK davidgumberg

2026-06-26

#35605
wallet: rpc: Deprecate `removeprunedfunds` RPC
Concept ACK achow101
#35610
bitcoin-util: Add netmagic command
Concept ACK pinheadmz
#35610
bitcoin-util: Add netmagic command
Concept ACK sedited
#35606
script: qa: Improve `Key::Fingerprint` type safety
Concept ACK pseudoramdom
#35604
log: expose `-logratelimit` in normal help
Concept ACK stickies-v
#35521
fuzz: Speed up `dbwrapper_concurrent_reads` harness
ACK nervana21
#35536
fuzz: share a single mocked steady clock across FuzzedSock instances
ACK maflcko
#35578
net: don’t self advertise tor exit node ip addresses in outbound connections
Concept ACK 0xB10C
#35602
doc: Clarify build docs about `pkgconf` / `pkg-config` requirements
ACK purpleKarrot
#35603
build: QRencode cleanups
ACK purpleKarrot
#35606
script: qa: Improve `Key::Fingerprint` type safety
Concept ACK w0xlt

2026-06-25

#35587
Remove boost as a unit test runner
Concept ACK w0xlt
#35601
wallet: remove experimental warning from send and sendall
ACK achow101
#35601
wallet: remove experimental warning from send and sendall
ACK w0xlt
#35601
wallet: remove experimental warning from send and sendall
ACK maflcko

2026-06-24

#35568
txospenderindex: disable bloom filters to optimize disk usage
Tested ACK l0rinc

2026-06-23

#35550
net_processing: fix BIP152 first integer interpretation
ACK achow101
#35450
[29.x] 29.4rc1
ACK l0rinc
#35570
refactor: Change some validation.cpp methods to return BlockValidationState
Concept ACK stringintech
#35452
[30.x] 30.3rc1
ACK l0rinc
#35543
test: introduce ExtendedPrivateKey and ExtendedPublicKey classes
ACK achow101
#35587
Remove boost as a unit test runner
Concept ACK josibake
#35569
Encapsulation for CTransaction
ACK josibake
#35587
Remove boost as a unit test runner
Concept ACK purpleKarrot

2026-06-22

#35581
node: add block template manager and track waitNext fee inflow
Concept ACK w0xlt
#35571
ci: use warp docker buildkit cache
ACK m3dwards
#35570
refactor: Change some validation.cpp methods to return BlockValidationState
Concept ACK purpleKarrot
#35576
test: raise `feature_reindex` RPC timeout
ACK mercie-ux

2026-06-21

#35569
Encapsulation for CTransaction
Concept ACK w0xlt
#35474
node: move index ownership to NodeContext
Concept ACK fjahr

2026-06-20

#35570
refactor: Change some validation.cpp methods to return BlockValidationState
Concept ACK w0xlt

2026-06-19

#35512
wallet: move fAbortRescan reset into WalletRescanReserver reserve function
ACK achow101
#35564
Update secp256k1 subtree to latest master
Concept ACK real-or-random
#35537
guix: split builds into Linux, Linux GUI and macOS/Windows
ACK hebasto
#35550
net_processing: fix BIP152 first integer interpretation
ACK Sjors
#35561
net: move some CNodeState fields to Peer
Concept ACK davidgumberg

2026-06-18

#35558
p2p: Prefill compact blocks
Concept ACK murchandamus
#35558
p2p: Prefill compact blocks
Concept ACK edilmedeiros
#35550
net_processing: fix BIP152 first integer interpretation
utACK edilmedeiros
#35558
p2p: Prefill compact blocks
Concept ACK josibake
#35558
p2p: Prefill compact blocks
Concept ACK ismaelsadeeq
#35465
coins: compact chainstate regularly
ACK optout21
#35558
p2p: Prefill compact blocks
Concept ACK w0xlt
#35559
scripted-diff: Rename SteadyClockContext to FakeSteadyClock
ACK maflcko

2026-06-17

#35550
net_processing: fix BIP152 first integer interpretation
Concept ACK yancyribbens
#35521
fuzz: Speed up `dbwrapper_concurrent_reads` harness
Concept ACK brunoerg
#35551
test: add interface_gui.py to test bitcoin-qt startup
Concept ACK sedited
#35549
argsman: Fix duplicate option assertion to allow HIDDEN category registration
Code Review ACK ryanofsky
#35465
coins: compact chainstate regularly
ACK sipa
#35496
kernel: add `btck_set_mock_time` for testing time-dependent paths
ACK josibake
#35547
lint: Require scripted-diff script to succeed
ACK maflcko
#35531
txindex: hash keys and pack positions to reduce disk usage
Concept ACK sedited
#35546
ci: Use GCC consistently in i686 task
ACK fanquake

2026-06-16

#35531
txindex: hash keys and pack positions to reduce disk usage
Concept ACK theStack
#35538
test: make TestChain100Setup's m_clock timestamp more readable
ACK maflcko

2026-06-15

#35511
RFC: consensus: Make `CAmount` a class
Concept ACK ryanofsky
#35503
guix: CMake-related improvements
ACK fanquake
#35535
iwyu: Fix warning in `bench/pool.cpp`
ACK fanquake
#35520
lint: remove redundant test suite uniqueness check
ACK maflcko
#35531
txindex: hash keys and pack positions to reduce disk usage
Concept ACK l0rinc
#35528
test: doc: remove `--perf` profiling from functional test framework
ACK maflcko
#35526
ci: bump MSan fuzz timeout from 150 to 180 minutes
ACK maflcko

2026-06-14

#35528
test: doc: remove `--perf` profiling from functional test framework
Code Review ACK l0rinc
#35470
argsman: Prevent duplicate option registration across categories
Concept ACK w0xlt

2026-06-13

#35527
Treat empty settings file as missing
Concept ACK winterrdog

2026-06-12

#35516
rpc: preserve global xpubs and proprietary fields in joinpsbts
Concept ACK achow101
#35506
test: ensure group data cluster pointers are live
Code Review ACK l0rinc
#35493
wallet, descriptor: Fix MuSig private key completeness checks on `importdescriptors`
Concept ACK theStack
#35519
rpc: tighten setmocktime upper bound to UINT32_MAX
Concept ACK sedited
#35498
net: move cs_main up in FetchBlock to fix rpc assert crash
ACK maflcko
#35519
rpc: tighten setmocktime upper bound to UINT32_MAX
ACK maflcko
#35497
test: FakeNodeClock follow-ups in unit tests
Tested ACK seduless
#35493
wallet, descriptor: Fix MuSig private key completeness checks on `importdescriptors`
Concept ACK rkrux
#35503
guix: CMake-related improvements
ACK fanquake
#35458
qa: Avoid extra tracebacks when exception is raised
ACK maflcko

2026-06-11

#35465
coins: compact chainstate regularly
Concept ACK w0xlt
#35514
ci: Alpine 3.24
ACK maflcko
#35496
kernel: add `btck_set_mock_time` for testing time-dependent paths
Concept ACK josibake
#35511
RFC: consensus: Make `CAmount` a class
Concept ACK sedited
#35501
wallet: store all witness variants of a transaction
Concept ACK polespinasa
#35502
refactor: extract per-message helpers from ProcessMessage (move-only)
Code Review ACK thomasbuilds
#35455
fuzz: improve dbwrapper_concurrent_reads performance
ACK l0rinc
#35502
refactor: extract per-message helpers from ProcessMessage (move-only)
Code Review ACK pseudoramdom
#35509
test: fix `--perf` profiling
Concept ACK w0xlt

2026-06-10

#35451
lint: Grep for `AUTO` test suites in file names
ACK achow101
#35455
fuzz: improve dbwrapper_concurrent_reads performance
reACK marcofleon
#35496
kernel: add `btck_set_mock_time` for testing time-dependent paths
Concept ACK stickies-v
#35502
refactor: extract per-message helpers from ProcessMessage (move-only)
Concept ACK stickies-v
#35478
fuzz: reset the mockable steady clock between iterations
ACK maflcko
#35493
wallet, descriptor: Fix MuSig private key completeness checks on `importdescriptors`
ACK b-l-u-e

2026-06-09

#35496
kernel: add `btck_set_mock_time` for testing time-dependent paths
Concept ACK sedited
#35490
test: cover unused mempool space in coins cache limit
Concept ACK sedited
#35487
scripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAME
ACK maflcko

2026-06-07

#35477
test: exercise Schnorr signature cache in txvalidationcache_tests.cpp
Concept ACK w0xlt

2026-06-06

#35474
node: move index ownership to NodeContext
Concept ACK sedited
#35466
ci: run ipc functional tests in arm job
ACK Sjors
#35470
argsman: Prevent duplicate option registration across categories
Concept ACK sedited
#35464
kernel: Add function for creating chainparams with a signet challenge
Concept ACK w0xlt

2026-06-05

#35464
kernel: Add function for creating chainparams with a signet challenge
Concept ACK oleonardolima
#35464
kernel: Add function for creating chainparams with a signet challenge
Concept ACK edilmedeiros
#35451
lint: Grep for `AUTO` test suites in file names
ACK l0rinc

2026-06-04

#35455
fuzz: improve dbwrapper_concurrent_reads performance
Code Review ACK l0rinc
#35451
lint: Grep for `AUTO` test suites in file names
Code Review ACK l0rinc
#35459
guix: add setup.sh
Concept ACK willcl-ark