Looking for NACKs? → nackamoto.com

Last updated at 2026-10-15 16:01 UTC

2026-10-15

#36521
Keep witness stacks in serialized form in CScriptWitness
Concept ACK rkrux
#36524
common: drop locale setting hack
ACK stickies-v
#36439
test: poll more frequently in sync helpers and RPC connection wait
ACK maflcko
#36535
policy: sum package weight in int64_t
ACK maflcko
#36524
common: drop locale setting hack
ACK maflcko
#36521
Keep witness stacks in serialized form in CScriptWitness
Concept ACK w0xlt
#36480
txospenderindex: hash keys and pack positions to reduce disk usage
Concept ACK w0xlt
#36525
mining: add getTotalFees(), protect m_block_template with mutex
Concept ACK w0xlt
#36496
coins: avoid redundant prevout preparation allocations
ACK andrewtoth
#36506
p2p: plug "tier 1" 1p1c liveness holes
reACK fametrano
#36521
Keep witness stacks in serialized form in CScriptWitness
Concept ACK instagibbs

2026-10-14

#36506
p2p: plug "tier 1" 1p1c liveness holes
ACK fametrano
#36524
common: drop locale setting hack
ACK maflcko
#36522
test: check MIN_PEER_PROTO_VERSION peers are not disconnected
ACK maflcko
#36521
Keep witness stacks in serialized form in CScriptWitness
Concept ACK 0xB10C
#36521
Keep witness stacks in serialized form in CScriptWitness
Concept ACK furszy
#36405
test: look for the wtxid in p2p_blocksonly
ACK maflcko
#36348
doc/i2p: mention -privatebroadcast bypasses persistent address
ACK davidgumberg

2026-10-13

#36494
wallet: reject unknown options in sendall
Concept ACK Conradgabe
#36469
refactor: deduplicate block validation state catcher
ACK maflcko
#36485
ci: refactor BUILD_TARGETS use
ACK fanquake

2026-10-12

#36466
policy: make unstructured Taproot annexes standard
utACK petertodd
#36470
test: make p2p_eviction actually exercise block-time protection
ACK maflcko
#36440
test: speed up functional tests by removing avoidable waits
ACK maflcko
#36449
addrman: use uniform sampling inside buckets
ACK Hamza1610
#36501
refactor : Reorder CBlockIndex members to save 8 bytes
ACK maflcko

2026-10-11

#36501
refactor : Reorder CBlockIndex members to save 8 bytes
ACK l0rinc
#36465
Test: Add P2SH scriptSig stack-size boundary tests
ACK ekzyis

2026-10-10

#36427
[32.x] More Backports
ACK andrewtoth
#36489
wallet: rpc: Add snake_case aliases for wallet funding options
Concept ACK kevkevinpal

2026-10-09

#36489
wallet: rpc: Add snake_case aliases for wallet funding options
Concept ACK psychemist
#36441
doc: fix How to Upgrade section for bitcoin wrapper and libexec
ACK tumutech
#36417
bip352: verify redeem script and pubkey hash in GetPubKeyFromInput
Tested ACK fametrano
#36480
txospenderindex: hash keys and pack positions to reduce disk usage
Concept ACK l0rinc
#36474
ci: Run valgrind --exclude tests again
ACK fanquake
#36475
bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case)
ACK Yudis-bit
#36358
[31.x] net: don't discourage private broadcast peers
ACK davidgumberg

2026-10-08

#36481
wallet, rpc, gui: Allow users to manually rebroadcast a wallet transaction
Concept ACK polespinasa
#36482
wallet: Only broadcast resubmitted transactions that were added to the mempool
Concept ACK polespinasa
#36453
util, cli: name the Sock wait timeout cap and use it for -rpcclienttimeout=0
Concept ACK pinheadmz
#36480
txospenderindex: hash keys and pack positions to reduce disk usage
Concept ACK andrewtoth
#36443
descriptor: Reconstruct a multipath descriptor from its expansion
Concept ACK w0xlt
#36444
wallet: Store information about created and imported multipath descriptors
Concept ACK w0xlt
#36442
descriptor: Represent multipath descriptors in a single Descriptor object
Concept ACK w0xlt
#36417
bip352: verify redeem script and pubkey hash in GetPubKeyFromInput
Concept ACK w0xlt
#36475
bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case)
Concept ACK w0xlt
#36356
mining: move getblocktemplate cache into BlockTemplateManager
Concept ACK w0xlt
#36469
refactor: deduplicate block validation state catcher
Concept ACK w0xlt
#36368
bitcoin-tx: reject in and outscript arguments with too many separators
Tested ACK cyb3ralbert
#36440
test: speed up functional tests by removing avoidable waits
Concept ACK sedited
#36460
doc: fix createwallet positional example, descriptors must be true
ACK treib-holdings
#36449
addrman: use uniform sampling inside buckets
reACK Hamza1610
#36347
node: don't abort on invalid -dbcache in settings.json
ACK Hamza1610
#36471
bitcoin-util: print genesis hash in display order
ACK maflcko
#36469
refactor: deduplicate block validation state catcher
Concept ACK sedited
#36464
rpc: prevent cross-origin calls with cached credentials
Concept ACK pinheadmz
#36453
util, cli: name the Sock wait timeout cap and use it for -rpcclienttimeout=0
ACK maflcko
#36460
doc: fix createwallet positional example, descriptors must be true
ACK maflcko
#36462
rpc: fix OpenRPC hex pattern to allow empty strings
ACK maflcko
#36330
wallet: don't resubmit transactions under -privatebroadcast
reACK davidgumberg
#36437
orphanage: Fix orphan reconsideration disconnect hole, add 1p1c invariant harness
Concept ACK w0xlt
#36450
test: Use timeout_factor for drain timeout in check_slow_read_throttle
Code Review ACK l0rinc
#36422
test: check unconnecting headers don't reset the getheaders rate limit
Concept ACK w0xlt

2026-10-07

#36441
doc: fix How to Upgrade section for bitcoin wrapper and libexec
ACK Naomi-Gift
#36449
addrman: use uniform sampling inside buckets
ACK instagibbs
#36456
Test: Cover malformed and truncated tx encodings
Concept ACK darosior
#36457
Test: Cover malformed merkle trees and nBits
Concept ACK darosior
#36449
addrman: use uniform sampling inside buckets
Concept ACK instagibbs
#36418
kernel: document that btck_WriteBytes may receive a null pointer
ACK stickies-v
#36449
addrman: use uniform sampling inside buckets
Concept ACK Hamza1610
#36405
test: look for the wtxid in p2p_blocksonly
Concept ACK mercie-ux
#36450
test: Use timeout_factor for drain timeout in check_slow_read_throttle
ACK pinheadmz
#36451
refactor: Use NotNull for CreateNewBlock and pimpls
Concept ACK stickies-v
#36451
refactor: Use NotNull for CreateNewBlock and pimpls
Concept ACK sedited
#36447
test: Misc fixes for pending validation events races
reACK willcl-ark
#36448
randomenv: use `KERN_POSIX1` over `KERN_OSREV`
ACK maflcko
#36438
test: a switch to tx relay via filterclear can trigger eviction
ACK mercie-ux

2026-10-06

#36440
test: speed up functional tests by removing avoidable waits
Concept ACK w0xlt
#36338
BIP-352: fix P2PKH pubkey extraction from malleated scriptSig
Tested ACK Yudis-bit
#36398
wallet: only rebroadcast transactions originating from the wallet
Concept ACK vasild

2026-10-05

#36347
node: don't abort on invalid -dbcache in settings.json
ACK 8144225309
#36303
http: Log bytes received from client, use to replace receive-throttle regression test
ACK achow101
#36402
refactor: `wallet_importdescriptors` to separate `run_test()` contents into specific functions
Concept ACK polespinasa

2026-10-04

#36349
rpc: avoid copying unbroadcast transaction IDs just to count them
ACK l0rinc
#36349
rpc: avoid copying unbroadcast transaction IDs just to count them
ACK maflcko
#36313
wallet: fix persistent coin lock upgrade
Tested ACK jcastros

2026-10-03

#36409
sign: use fresh randomness as BIP340 auxiliary data
ACK Yudis-bit
#36420
descriptor: compare x-only public keys in Tapscript Miniscript duplicate check
reACK fametrano
#36393
wallet: enforce max_tx_weight for preset inputs
ACK jcastros
#36426
test: check IBD insufficient work disconnect of outbound peers
ACK kevkevinpal
#36313
wallet: fix persistent coin lock upgrade
Concept ACK jcastros
#36420
descriptor: compare x-only public keys in Tapscript Miniscript duplicate check
ACK fametrano
#36343
psbt: verify final scripts in FinalizePSBT
Tested ACK fametrano
#36415
rpc: clarify preciousblock help text
ACK maflcko

2026-10-02

#36404
fuzz: don't set random state for private broadcast test
ACK achow101
#36299
cli: Improve empty-response and fix -rpcclienttimeout regression
ACK achow101
#36415
rpc: clarify preciousblock help text
ACK instagibbs
#36407
test: make orphanage_dos_many fill the orphanage
ACK instagibbs
#36406
test: make p2p_orphan_handling's never-requested checks able to fail
ACK instagibbs
#36262
test: cover orphan reconsideration interruptibility
reACK instagibbs
#36340
util: cap Sock::WaitMany timeout to fix -rpcclienttimeout=0 on macOS
ACK fjahr
#36411
ci: drop `-Wno-error=maybe-uninitialized` from win64 cxx flags
ACK maflcko
#36416
test: use ipaddress in addr_to_hex
Concept ACK sipa
#36415
rpc: clarify preciousblock help text
ACK maflcko
#36329
psbt: add new test vectors
ACK fametrano
#36343
psbt: verify final scripts in FinalizePSBT
Tested ACK fametrano
#36412
ci: drop `-U_FORTIFY_SOURCE` from TSAN job
ACK maflcko
#36392
test: Extract and use sigterm_node in init_fd_overflow_test
ACK fametrano
#36404
fuzz: don't set random state for private broadcast test
ACK kevkevinpal

2026-10-01

#36291
test: add script_tests cases covering interpreter mutants
ACK fametrano
#36332
sign: add musig2 data after validating musig2 involvement
ACK fametrano
#36395
script: clarify implicit signature-cache input requirements
Concept ACK instagibbs
#36299
cli: Improve empty-response and fix -rpcclienttimeout regression
Concept ACK l0rinc
#36340
util: cap Sock::WaitMany timeout to fix -rpcclienttimeout=0 on macOS
Concept ACK l0rinc
#36400
[32.x] 32.0rc3
ACK instagibbs
#36400
[32.x] 32.0rc3
ACK marcofleon
#36383
util: remove unused exception parameter in `Popen::execute_process`
ACK maflcko
#36378
test: Add SKIP_WRITE edge case to wallet_startup
ACK mercie-ux
#36299
cli: Improve empty-response and fix -rpcclienttimeout regression
Tested ACK b-l-u-e
#36384
rpc: Use self.Arg<_>(name) helper over manual and duplicate parsing
Concept ACK fanquake

2026-09-30

#36348
doc/i2p: mention -privatebroadcast bypasses persistent address
ACK davidgumberg
#36391
test: fix typo in rpc_psbt
ACK janb84
#36338
BIP-352: fix P2PKH pubkey extraction from malleated scriptSig
ACK achow101
#36389
refactor: deduplicate block validation state catcher
Concept ACK w0xlt
#36387
wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.
Concept ACK w0xlt
#36391
test: fix typo in rpc_psbt
ACK maflcko
#36300
[32.x] More Backports
ACK willcl-ark
#36317
mempool, fees: stop treating different witness variants as mined
Concept ACK mercie-ux
#36381
test: avoid testing at the exact `-maxfeerate` boundary
ACK polespinasa
#36320
test: refactor: make chain_dir consistent with CreateBaseChainParams
ACK maflcko
#36320
test: refactor: make chain_dir consistent with CreateBaseChainParams
reACK ismaelsadeeq
#36300
[32.x] More Backports
ACK ismaelsadeeq
#36387
wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.
Concept ACK pseudoramdom
#36333
wallet: Delete `removeprunedfunds` and delete transaction delete code
Concept ACK w0xlt

2026-09-29

#36344
wallet: reject duplicate inputs in sendall
ACK achow101
#36336
log: move CreateNewBlock() log line behind a new mining category
ACK achow101
#36365
fees: fall back to `block_policy` and minor api change
ACK achow101
#36336
log: move CreateNewBlock() log line behind a new mining category
reACK l0rinc
#36377
doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md
ACK davidgumberg
#36381
test: avoid testing at the exact `-maxfeerate` boundary
ACK davidgumberg
#36381
test: avoid testing at the exact `-maxfeerate` boundary
ACK achow101
#36377
doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md
ACK achow101
#36381
test: avoid testing at the exact `-maxfeerate` boundary
ACK maflcko
#36368
bitcoin-tx: reject in and outscript arguments with too many separators
ACK maflcko
#36275
build: enable `-Wunused-const-variable`
ACK maflcko
#36366
net: limit relative ban times to uint32
ACK maflcko
#36339
wallet: avoid int overflow in listtransactions
ACK maflcko

2026-09-28

#36365
fees: fall back to `block_policy` and minor api change
reACK davidgumberg
#36369
p2p: don't let one peer's same-txid variant cancel another peer's 1p1c or orphan resolution
Concept ACK darosior
#36342
wallet: reject recipient amounts above MAX_MONEY
ACK maflcko
#36355
http: do not process requests pipelined behind "Connection: close"
Concept ACK pinheadmz
#36336
log: move CreateNewBlock() log line behind a new mining category
ACK Sjors
#36365
fees: fall back to `block_policy` and minor api change
Concept ACK kevkevinpal
#36327
test: speed up secp256k1 fixed-base multiplication and Schnorr signing
Concept ACK theStack
#36280
validation: throw when a compressed script can't be decompressed
ACK purpleKarrot
#36357
mining: move BlockAssembler statics into BlockTemplateManager
Concept ACK ismaelsadeeq
#36364
tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet
ACK maflcko
#36341
wallet: return error from bitcoin-wallet create
ACK maflcko

2026-09-27

#36329
psbt: add new test vectors
reACK aaron-leeb

2026-09-25

#36327
test: speed up secp256k1 fixed-base multiplication and Schnorr signing
ACK StephenChi-hi
#36336
log: move CreateNewBlock() log line behind a new mining category
Concept ACK sedited
#36335
Remove my key from SECURITY.md
ACK Sjors
#36335
Remove my key from SECURITY.md
ACK Sjors
#36329
psbt: add new test vectors
reACK brunoerg
#36322
init: fee estimates can lag behind the chain after restart
ACK maflcko
#36317
mempool, fees: stop treating different witness variants as mined
ACK ismaelsadeeq
#36329
psbt: add new test vectors
ACK aaron-leeb

2026-09-24

#36284
wallet: don't double discard output groups with avoidpartialspends
ACK achow101
#36321
net: cast vector size to avoid overflow, truncation, sign change
ACK maflcko
#36326
kernel: Use typed errors for fatal and flush error notifications
Concept ACK sedited

2026-09-23

#36312
net: don't discourage private broadcast peers
reACK instagibbs
#36312
net: don't discourage private broadcast peers
ACK instagibbs
#36252
ci, iwyu: skip subtrees in compilation database
ACK David-Uka
#36294
mempool: Remove -persistmempoolv1 option
Concept ACK ismaelsadeeq
#36317
mempool, fees: stop treating different witness variants as mined
Concept ACK ismaelsadeeq

2026-09-22

#36309
private broadcast: clarify claims, mark as experimental
ACK davidgumberg
#36309
private broadcast: clarify claims, mark as experimental
reACK l0rinc
#36295
refactor: Remove args-wrappers in favor of naked value_or()
Concept ACK stickies-v
#36261
test: cover PSBT unknown field merging
ACK polespinasa
#36310
rpc: clarify that `getaddrmaninfo` counts unique addresses
ACK fjahr

2026-09-21

#36309
private broadcast: clarify claims, mark as experimental
reACK l0rinc
#36309
private broadcast: clarify claims, mark as experimental
ACK l0rinc
#36302
ci: simplify macOS codesign check
ACK Sjors
#36283
kernel: expose transaction version
ACK stickies-v

2026-09-20

#36303
http: Log bytes received from client, use to replace receive-throttle regression test
Tested ACK 151henry151
#36302
ci: simplify macOS codesign check
ACK maflcko

2026-09-19

#36287
build: Bump Xcode CLT minimum supported version to 26.3
Concept ACK fanquake
#36297
rpc: Correct invalid OpenRPC defaults
ACK nervana21
#36297
rpc: Correct invalid OpenRPC defaults
ACK maflcko
#36297
rpc: Correct invalid OpenRPC defaults
Concept ACK nervana21

2026-09-18

#36295
refactor: Remove args-wrappers in favor of naked value_or()
Code Review ACK l0rinc
#36288
build: Revert remove `cmake/script/CoverageFuzz.cmake`"
ACK marcofleon

2026-09-17

#36288
build: Revert remove `cmake/script/CoverageFuzz.cmake`"
ACK kevkevinpal
#36288
build: Revert remove `cmake/script/CoverageFuzz.cmake`"
Concept ACK maflcko
#36283
kernel: expose transaction version
Concept ACK yuvicc

2026-09-16

#36282
Update leveldb subtree to latest master
Code Review ACK l0rinc
#36280
validation: throw when a compressed script can't be decompressed
ACK sedited
#36261
test: cover PSBT unknown field merging
ACK w0xlt
#36277
net: always complete all initial private broadcast connections
Concept ACK vasild
#36262
test: cover orphan reconsideration interruptibility
Concept ACK instagibbs
#36260
torcontrol: Use reconnect backoff after dropped connections
Concept ACK fanquake
#36256
guix: Update osslsigncode to 2.14
utACK Sjors

2026-09-15

#36255
Refactor CoinGrinder tests
Concept ACK yancyribbens
#36250
rpc: clarify sendrawtransaction decode error
ACK l0rinc

2026-09-14

#36250
rpc: clarify sendrawtransaction decode error
ACK Rob1Ham
#36251
rest: add `generated` and `height` to spenttxouts JSON
Concept ACK sedited
#36246
[32.x] Bump to 32.0rc1
ACK fanquake
#36247
iwyu: Always keep `bitcoin-build-info.h` header
ACK fanquake