Looking for NACKs? → nackamoto.com

Last updated at 2026-04-17 08:32 UTC

2026-04-17

#35095
doc: fix typos and minor formatting issues
ACK maflcko

2026-04-16

#35078
validation: merge `PeekCoin` into `GetCoin`
Concept ACK ryanofsky
#35086
test: interface_http follow-ups
Code Review ACK fjahr
#35089
test: Allow to set height in create_block
reACK l0rinc
#35090
fuzz: add p2p_private_broadcast harness
Concept ACK vasild

2026-04-15

#35084
ipc: Support for windows support
Concept ACK stickies-v
#35069
Refactor keypath parser
Concept ACK Sjors
#35003
validation: improve block data I/O error handling in P2P paths
Concept ACK rkrux
#35080
test: Add missing self.options.timeout_factor scale in tool_bitcoin_chainstate.py
ACK fanquake

2026-04-14

#35077
kernel: build: remove unused serfloat dependency
ACK davidgumberg
#35038
bench: add script verification benchmark for P2TR script-path spends
reACK davidgumberg
#35018
wallet, bench: Use Nanobench setup() for wallet benchmarks, and remove DuplicateMockDatabase
Concept ACK theStack
#35003
validation: improve block data I/O error handling in P2P paths
ACK maflcko

2026-04-13

#35038
bench: add script verification benchmark for P2TR script-path spends
reACK davidgumberg
#35037
ipc: support per-address max-connections options on -ipcbind
Concept ACK kevkevinpal
#35024
ci: Mitigate network issues in native Windows job
ACK maflcko
#34865
logging: better use of log::Entry internally
Code Review ACK ryanofsky

2026-04-12

#35054
p2p: UTXO set sharing
Concept ACK andrewtoth
#35000
test: Add block validation unit tests
Concept ACK w0xlt

2026-04-10

#35047
doc: fix typo 'parlor' to 'parlance' in developer-notes
ACK l0rinc
#35047
doc: fix typo 'parlor' to 'parlance' in developer-notes
ACK maflcko

2026-04-09

#34858
test: Use NodeClockContext in more tests
ACK achow101
#34886
test: Rework Single Random Draw coin selection tests
ACK achow101
#35032
net_processing: don't modify addrman for private broadcast connections
ACK achow101
#34922
test: Use BasicTestingSetup when sufficient
ACK achow101
#34922
test: Use BasicTestingSetup when sufficient
ACK l0rinc
#35037
ipc: support per-address max-connections options on -ipcbind
Concept ACK ryanofsky
#35036
ipc: support per-address max-connections options on -ipcbind
Concept ACK ryanofsky
#35032
net_processing: don't modify addrman for private broadcast connections
ACK instagibbs
#35032
net_processing: don't modify addrman for private broadcast connections
Code Review ACK l0rinc
#35032
net_processing: don't modify addrman for private broadcast connections
ACK andrewtoth

2026-04-08

#35034
[31.x] Fix guix build and rc4
ACK davidgumberg
#35034
[31.x] Fix guix build and rc4
Concept ACK m3dwards
#35034
[31.x] Fix guix build and rc4
Concept ACK svanstaa
#34905
Update string and net utils for future HTTP operations
Code Review ACK fjahr
#35034
[31.x] Fix guix build and rc4
Concept ACK pinheadmz
#35032
net_processing: don't modify addrman for private broadcast connections
ACK instagibbs
#35028
[31.x] Backports + rc3
utACK Sjors

2026-04-07

#35014
test: remove macOS REDUCE_EXPORTS exception workaround
ACK achow101
#34897
indexes: Don't commit ahead of the flushed chainstate
Concept ACK ryanofsky
#34977
Update libmultiprocess subtree to fix test timeout
ACK achow101
#35009
wallet, rpc: add include_change parameter to listtransactions
ACK achow101
#34884
validation: remove unused code in FindMostWorkChain
Code Review ACK fjahr
#34999
refactor: pre-push-hook.sh potential regression
Concept ACK maflcko
#35001
validation: Remove stale `BlockManager` param from `ContextualCheckBlockHeader`
ACK maflcko
#35018
wallet, bench: Use Nanobench setup() for wallet benchmarks, and remove DuplicateMockDatabase
Concept ACK davidgumberg

2026-04-06

#35003
validation: improve block data I/O error handling in P2P paths
Concept ACK pinheadmz
#35011
ci, iwyu: Fix warnings in `src/script` and treat them as errors
Concept ACK kevkevinpal
#34989
doc: remove stale shortid collision TODO
ACK instagibbs
#34989
doc: remove stale shortid collision TODO
ACK l0rinc
#34967
doc: Discourage trailing doxygen comments, and fix the broken ones
ACK l0rinc

2026-04-04

#34997
p2p: Don't participate in addr relay with feelers
Concept ACK taki-abedesselam
#34863
test: Clean shutdown in Socks5Server
ACK achow101
#34873
net: fix premature stale flagging of unpicked private broadcast txs
ACK achow101

2026-04-03

#34991
test: fix feature_index_prune.py bug when using --usecli
ACK Bicaru20

2026-04-02

#34991
test: fix feature_index_prune.py bug when using --usecli
Concept ACK w0xlt
#34965
cli: Return more helpful authentication errors
ACK achow101
#34965
cli: Return more helpful authentication errors
ACK maflcko
#34887
fuzz: target CDBWrapper
Concept ACK marcofleon
#34988
rpc: fix initialization-order-fiasco by lazy-init of decodepsbt_inputs
Concept ACK maflcko

2026-04-01

#34978
init: Reserve file descriptors for IPC connections
Concept ACK w0xlt
#34905
Update string and net utils for future HTTP operations
Code Review ACK fjahr
#34976
lint: Clarify rmtree/remove_all error message with preferred alternatives
ACK achow101
#34988
rpc: fix initialization-order-fiasco by lazy-init of decodepsbt_inputs
ACK davidgumberg
#34980
Require captcha for all pull request submissions to prevent LLM abuse
ACK dathonohm
#34965
cli: Return more helpful authentication errors
utACK davidgumberg
#34976
lint: Clarify rmtree/remove_all error message with preferred alternatives
ACK davidgumberg
#34982
kernel: Remove NONNULL annotation from destroy method
ACK achow101
#34986
docs: remove duplicate ///@} from bitcoinkernel.h
ACK kevkevinpal
#34980
Require captcha for all pull request submissions to prevent LLM abuse
Concept ACK hsmiranda
#34982
kernel: Remove NONNULL annotation from destroy method
ACK kevkevinpal
#34986
docs: remove duplicate ///@} from bitcoinkernel.h
ACK maflcko
#34982
kernel: Remove NONNULL annotation from destroy method
ACK yuvicc
#34980
Require captcha for all pull request submissions to prevent LLM abuse
Concept ACK polespinasa
#34957
policy: remove incorrect `MANDATORY_SCRIPT_VERIFY_FLAGS` comment
utACK ajtowns
#34956
depends, qt: Fix build on aarch64 macOS 26.4
ACK fanquake

2026-03-31

#34935
cli: Return more correct error on -norpccookiefile without -rpcpassword
ACK maflcko
#34958
test: mining: add coverage for GBT's "coinbasevalue" result field
ACK Sjors
#34958
test: mining: add coverage for GBT's "coinbasevalue" result field
ACK maflcko

2026-03-30

#34811
doc: update cjdns.md for current cjdns installation and peering
ACK achow101
#34882
refactor: Use NodeClock::time_point in more places
Concept ACK stickies-v
#34804
Update libmultiprocess subtree to fix race conditions on disconnects
ACK ismaelsadeeq
#34952
Update libmultiprocess subtree in 31.x branch to fix race conditions on disconnects
ACK Sjors
#34804
Update libmultiprocess subtree to fix race conditions on disconnects
ACK Sjors
#34943
ci: add delay between commits while testing all ancestor commits
ACK maflcko

2026-03-27

#34804
Update libmultiprocess subtree to fix race conditions on disconnects
ACK Sjors
#34926
test: Replace DEBUG_LOG_OUT with -printtoconsole=1
ACK maflcko
#34938
refactor: Return std::optional over bool+mut&
Concept ACK stickies-v
#34934
fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness
ACK maflcko
#34931
validation: abort on DB unreadable coins instead of treating them as missing
Concept ACK fjahr

2026-03-26

#34861
wallet: Add importdescriptors interface
Concept ACK davidgumberg
#34931
validation: abort on DB unreadable coins instead of treating them as missing
Concept ACK w0xlt
#34931
validation: abort on DB unreadable coins instead of treating them as missing
Concept ACK stickies-v
#34922
test: Use BasicTestingSetup when sufficient
ACK maflcko
#34886
test: Rework Single Random Draw coin selection tests
reACK brunoerg

2026-03-25

#34919
test: script: boundary at exactly 65535 bytes must use OP_PUSHDATA2
Concept ACK danielabrozzoni
#34800
[31.x] Backports
ACK achow101
#34915
doc: archive release notes for v28.4
ACK achow101
#34804
Update libmultiprocess subtree to fix race conditions on disconnects
Concept ACK ismaelsadeeq
#34920
wallet: drop stale TODOs
ACK kevkevinpal
#34920
wallet: drop stale TODOs
ACK polespinasa
#34897
indexes: Don't commit ahead of the flushed chainstate
Concept ACK l0rinc
#34911
rpc, mempool: remove fullrbf remnants
Concept ACK ismaelsadeeq
#34800
[31.x] Backports
ACK Sjors
#34896
ci: Upgrade IWYU to 0.26 compatible with Clang 22
ACK fanquake

2026-03-24

#34800
[31.x] Backports
ACK Sjors
#34891
doc: Note that generateblock does not collect transaction fees
ACK maflcko
#34884
validation: remove unused code in FindMostWorkChain
Concept ACK fjahr
#34870
wallet: feebumper, fix crash when combined bump fee is unavailable
ACK achow101

2026-03-23

#34888
wallet: fix amount computed as boolean in coin selection
ACK achow101
#34886
test: Rework Single Random Draw coin selection tests
Concept ACK brunoerg
#34897
indexes: Don't commit ahead of the flushed chainstate
Concept ACK fjahr
#34850
depends: Remove no longer necessary `dsymutil`
ACK fanquake
#34888
wallet: fix amount computed as boolean in coin selection
Concept ACK l0rinc

2026-03-22

#34878
depends: Fix cross-compiling on macOS for Windows
ACK fanquake
#34886
test: Rework Single Random Draw coin selection tests
Concept ACK yancyribbens
#34877
guix: Remove `make-lld-wrapper`
ACK trevarj
#34888
wallet: fix amount computed as boolean in coin selection
utACK fjahr
#34861
wallet: Add importdescriptors interface
ACK w0xlt
#34860
mining: always pad scriptSig at low heights, drop include_dummy_extranonce
Concept ACK w0xlt
#34873
net: fix premature stale flagging of unpicked private broadcast txs
Concept ACK w0xlt
#34884
validation: remove unused code in FindMostWorkChain
Concept ACK w0xlt
#34886
test: Rework Single Random Draw coin selection tests
ACK w0xlt
#34873
net: fix premature stale flagging of unpicked private broadcast txs
ACK Mccalabrese

2026-03-21

#34873
net: fix premature stale flagging of unpicked private broadcast txs
ACK andrewtoth

2026-03-20

#34867
wallet: document importdescriptors error object fields
Concept ACK willcl-ark
#34884
validation: remove unused code in FindMostWorkChain
Concept ACK stickies-v
#34794
rest: add Cache-Control headers to REST responses
Concept ACK optout21
#34861
wallet: Add importdescriptors interface
Concept ACK stickies-v
#34869
tests: applied PYTHON_GIL to the env for every test
ACK fanquake

2026-03-19

#34869
tests: applied PYTHON_GIL to the env for every test
ACK maflcko
#34842
contrib: add ASmap attestation scripts
Concept ACK sedited
#34861
wallet: Add importdescriptors interface
Concept ACK sedited
#34861
wallet: Add importdescriptors interface
Concept ACK Sjors
#34850
depends: Remove no longer necessary `dsymutil`
Concept ACK fanquake

2026-03-18

#34824
net: refactor: replace Peer::TxRelay RecursiveMutex instances with Mutex
Concept ACK theuni
#34852
test: Fix intermittent issue in feature_assumeutxo.py
Code Review ACK fjahr
#34799
rpc: Run type check on decodepsbt result
ACK achow101

2026-03-17

#34844
util: Add util::NotNull<SmartPtrType>
Concept ACK stickies-v
#34832
lint: detect arch for mlc binary
ACK fanquake
#34830
fuzz: set fSuccessfullyConnected in connman harness
ACK maflcko
#34832
lint: detect arch for mlc binary
ACK maflcko
#34832
lint: detect arch for mlc binary
Concept ACK fanquake

2026-03-16

#34831
lint: remove excluded files from whitespace check
ACK kevkevinpal
#34833
test: add addnode connection limit test to rpc_net.py
Concept ACK kevkevinpal
#34808
cmake, translation: Use native Qt TS file as source for translations on Transifex
Code Review ACK l0rinc
#34811
doc: update cjdns.md for current cjdns installation and peering
Concept ACK brunoerg
#34831
lint: remove excluded files from whitespace check
ACK maflcko
#34816
test: Remove vulture from ci, Remove some --min-confidence=60 unused code
ACK fanquake

2026-03-14

#34803
mempool: asynchronous mempool fee rate diagram updates via validation interface
Concept ACK sedited

2026-03-13

#34799
rpc: Run type check on decodepsbt result
Concept ACK nervana21
#34820
test: Use asyncio.SelectorEventLoop() over deprecated asyncio.WindowsSelectorEventLoopPolicy(), move loop creation
ACK l0rinc
#34791
test: Suppress another unsolicited `mock_process/*` output
ACK maflcko

2026-03-12

#34816
test: Remove vulture from ci, Remove some --min-confidence=60 unused code
Code Review ACK l0rinc
#34813
threads: qa: Add lock order annotation for `TxMempool::cs`
Tested ACK sedited
#34815
ci: bump cirruslabs actions versions
ACK maflcko
#34813
threads: qa: Add lock order annotation for `TxMempool::cs`
Concept ACK hebasto
#34814
lint: Temporarily revert to vulture==2.14
ACK fanquake
#34813
threads: qa: Add lock order annotation for `TxMempool::cs`
Concept ACK sedited

2026-03-11

#34799
rpc: Run type check on decodepsbt result
Concept ACK willcl-ark
#34809
threadsafety: Add STDLOCK() macro for StdMutex
Concept ACK w0xlt
#34802
ci: Bump GHA actions versions
ACK fanquake
#34794
rest: add Cache-Control headers to REST responses
Concept ACK sedited
#34796
rpc, net: remove `startingheight` field of `getpeerinfo` RPC and from node state
ACK maflcko
#34792
clusterlin: update SFL comments for deterministic order
ACK achow101

2026-03-10

#34792
clusterlin: update SFL comments for deterministic order
ACK marcofleon
#34789
doc: update build guides pre v31
ACK maflcko