Looking for NACKs? → nackamoto.com

Last updated at 2026-08-30 15:46 UTC

2026-08-29

#35958
net: align v2 message type validation with v1 range
utACK ajtowns
#36015
txorphanage: bound orphan memory by storing transactions serialized
Concept ACK Crypt-iQ

2026-08-28

#36048
util: keep wallet names literal in notification commands
ACK maflcko
#36076
psbt: preserve sighash type when merging inputs
Concept ACK Sjors
#36054
test: add script_tests cases covering interpreter mutants
ACK instagibbs
#36107
iwyu: Fix warnings in `src/init` and treat them as errors
ACK maflcko
#36101
doc: Add an error handling strategy
Concept ACK josibake
#36111
rpc: bound memory for overlong Bech32 errors
ACK maflcko

2026-08-27

#36098
fuzz: add corpus reachability checks
Concept ACK brunoerg
#36102
util: Replace !ContainsNoNUL() with ContainsNUL()
Code Review ACK l0rinc
#35868
rpc, wallet: fix invalid JSON in HelpExampleRpc curl examples
ACK maflcko
#36102
util: Replace !ContainsNoNUL() with ContainsNUL()
ACK maflcko
#36100
ci: use LLVM 23 in *san, fuzz, *cross jobs
Concept ACK l0rinc
#36101
doc: Add an error handling strategy
Concept ACK sedited
#36057
build: check for SetThreadDescription() at configure time
utACK fanquake
#36094
ci: bump riscv toolchain to tag 2026.08.25
ACK maflcko
#36055
p2p: use header time for compact block recency
Concept ACK instagibbs
#36095
fees: validate persisted mempool policy estimator data after restoration
Concept ACK sedited

2026-08-26

#35850
fuzz: Implement `connect_block` harness
ACK Crypt-iQ
#36044
test: cover OP_SUCCESSx bypassing the initial stack element size limit
ACK instagibbs
#36083
test: cover getrawtransaction on a stale block via txindex
Concept ACK l0rinc
#35975
wallet: Fix `CWalletTx` malleated transaction metadata sync
Concept ACK rkrux
#36088
util: Set Univalue to null after read failure
ACK rustaceanrob
#36092
fix: UB sanitizer in mempool estimator logging
ACK maflcko
#36091
test: Add debug output to common tested types
Concept ACK brunoerg
#36091
test: Add debug output to common tested types
Concept ACK sedited
#35935
wallet: Avoid unnecessary wtxvariant rewrites
Concept ACK rkrux
#35998
wallet: Handle or explicitly ignore `WalletBatch` write failures
Concept ACK rkrux
#36031
wallet: Remove mapMasterKeys and enforce that only one encryption key can exist
Concept ACK rkrux
#36085
build: respect CMAKE_INSTALL_BINDIR and CMAKE_INSTALL_LIBEXECDIR in the launcher
ACK riba2534
#36085
build: respect CMAKE_INSTALL_BINDIR and CMAKE_INSTALL_LIBEXECDIR in the launcher
ACK purpleKarrot

2026-08-25

#36032
rpc: avoid quadratic output lookups
ACK achow101
#36078
qa: Reduce `-maxconnections` in the functional test framework
ACK pinheadmz
#36078
qa: Reduce `-maxconnections` in the functional test framework
ACK achow101
#36081
rpc: add bestblockhash to getmininginfo
Concept ACK Sjors
#36078
qa: Reduce `-maxconnections` in the functional test framework
Concept ACK pinheadmz
#36077
bugfix: give TxDownloadManager its own RNG
ACK maflcko
#36076
psbt: preserve sighash type when merging inputs
ACK jpk68
#35935
wallet: Avoid unnecessary wtxvariant rewrites
ACK jeanpablojp
#36070
wallet: Add deriveHDKey interface
Concept ACK polespinasa
#36067
test: Remove `BOOST_CHECK_CLOSE` in favor of exact comparison
ACK l0rinc

2026-08-24

#36025
psbt: avoid duplicate taproot leaf script keys when merging
ACK achow101
#35948
init: correct first-run disk space estimate
ACK achow101
#36064
qa: Minor improvement follow-ups to 35730
ACK pinheadmz
#36048
util: keep wallet names literal in notification commands
Concept ACK Sjors
#35978
contrib/init: fix unused variables in openrc script
ACK thomasbuilds
#36031
wallet: Remove mapMasterKeys and enforce that only one encryption key can exist
Concept ACK theStack
#36067
test: Remove `BOOST_CHECK_CLOSE` in favor of exact comparison
ACK josibake
#36067
test: Remove `BOOST_CHECK_CLOSE` in favor of exact comparison
ACK maflcko
#36063
refactor: [test] Remove deprecated SetMockTime(i64) alias
ACK rustaceanrob
#36046
fuzz: Use ImmediateBackgroundTaskRunner in process_messages
ACK Crypt-iQ

2026-08-23

#35933
psbt: don't abort on invalid MuSig2 derivations
Concept ACK nkaretnikov

2026-08-21

#36054
test: add script_tests cases covering interpreter mutants
Concept ACK brunoerg
#36033
[wip,nomerge,rfc] build: Require C++23 compiler
Concept ACK l0rinc
#36019
bench: Construct CTxOut and COutPoint in a single expression
reACK josibake
#36019
bench: Construct CTxOut and COutPoint in a single expression
ACK maflcko
#36040
Wallet: Don't backdate locktime rbf
Concept ACK nervana21
#36019
bench: Construct CTxOut and COutPoint in a single expression
Code Review ACK l0rinc

2026-08-20

#36048
util: keep wallet names literal in notification commands
Concept ACK achow101
#36032
rpc: avoid quadratic output lookups
Concept ACK jonatack
#36045
test: avoid undersized Boost.Test signal stacks
ACK maflcko
#35884
util: set os-level thread names on Windows
Code Review ACK l0rinc
#36025
psbt: avoid duplicate taproot leaf script keys when merging
ACK thomasbuilds

2026-08-19

#35887
ipc: use std::optional for checkSpawned(), add tests and rename arg -ipcfd to -ipcchild
ACK jeanpablojp
#36018
test: [refactor] Properly use BOOST_CHECK_EXCEPTION
ACK l0rinc
#35965
test: Tighten Coin equality and add debug output
ACK l0rinc
#35859
wallet: use unsigned KDF iteration count
ACK achow101
#35949
miner: Enforce Murch-Zawy rule (BIP54)
Concept ACK Sjors
#35978
contrib/init: fix unused variables in openrc script
utACK jeanpablojp
#35956
fuzz: scope fake clocks to target phases
ACK maflcko
#35965
test: Tighten Coin equality and add debug output
ACK maflcko
#35965
test: Tighten Coin equality and add debug output
reACK josibake

2026-08-18

#36015
txorphanage: bound orphan memory by storing transactions serialized
Concept ACK l0rinc
#36008
wallet: WalletBatch->WriteVersion respect argument
ACK achow101
#36013
test: Descriptor roundtrip and raw()/ addr() coverage
Concept ACK w0xlt
#36015
txorphanage: bound orphan memory by storing transactions serialized
Concept ACK w0xlt
#35994
Primitives: Combine assignments
Concept ACK josibake
#36007
http: Make HTTPRequest::m_client a weak_ptr
utACK fjahr
#35965
test: Tighten Coin equality and add debug output
ACK josibake
#35954
qa: Disable Qt's glib event dispatcher for GUI tests on OpenBSD
ACK maflcko
#35859
wallet: use unsigned KDF iteration count
Code Review ACK l0rinc
#35995
doc: fix outdated URL in hash_tests.cpp
ACK maflcko
#35986
p2p: reconsider orphans when missing inputs are mined
ACK yuvicc
#35997
refactor: bench: make_hard_case to find a solution
ACK Dontbyshai
#36002
txindex: allow running in pruned mode
Concept ACK l0rinc

2026-08-17

#35984
sign: skip signing SIGHASH_SINGLE inputs with no corresponding output
ACK achow101
#35980
contrib: reject divergent verify-commits history
ACK achow101
#35968
test: sync funding block before isolating nodes
ACK achow101
#35963
doc : update cjdns docs to discourage using onlynet option
ACK achow101
#35955
wallet: remove orphaned GetAffectedKeys and LegacyScriptPubKeyMan declarations
ACK achow101
#35946
rpc: Improve some type specs for openrpc
ACK achow101
#35998
wallet: Handle or explicitly ignore `WalletBatch` write failures
Concept ACK l0rinc
#35936
net: reject oversized locators before allocating
ACK achow101
#35994
Primitives: Combine assignments
Concept ACK l0rinc
#35902
zmq: Log bind error at Error level, abort startup on init error
ACK jeanpablojp
#35952
kernel: prevent dangling iterators from temporary ranges
ACK purpleKarrot
#35963
doc : update cjdns docs to discourage using onlynet option
Concept ACK brunoerg
#35993
guix: build glibc with `--enable-kernel=3.17.0`
Concept ACK hebasto
#35976
test: Speedup fee estimation functional test with batching
ACK maflcko
#35986
p2p: reconsider orphans when missing inputs are mined
Concept ACK yuvicc

2026-08-16

#35972
fuzz: Fix assertion in `txorphan`
Concept ACK nervana21

2026-08-15

#35984
sign: skip signing SIGHASH_SINGLE inputs with no corresponding output
Concept ACK l0rinc

2026-08-14

#35933
psbt: don't abort on invalid MuSig2 derivations
ACK achow101
#35976
test: Speedup fee estimation functional test with batching
Concept ACK ismaelsadeeq
#35971
net_processing: remove unused code
ACK marcofleon
#35906
First steps towards a stateless, side-effect free validation library
Concept ACK josibake

2026-08-13

#35852
scripted-diff: Use inline const(expr) over static constexpr in headers
ACK rustaceanrob

2026-08-12

#35866
test: Verify unwelcome RPC clients are rejected before reading their requests
ACK achow101
#35959
Update secp256k1 subtree to latest master
ACK achow101
#35959
Update secp256k1 subtree to latest master
ACK l0rinc
#35951
doc: release note about I2P ElGamal sunset
ACK zzzi2p
#35955
wallet: remove orphaned GetAffectedKeys and LegacyScriptPubKeyMan declarations
ACK shuv-amp
#35949
miner: Enforce Murch-Zawy rule (BIP54)
Concept ACK kevkevinpal
#35945
depends, qt: Add patch for missing headers
ACK fanquake
#35947
build, msvc: Update vcpkg manifest baseline
ACK fanquake
#35893
test: cover submitpackage other-wtxid for same-txid-diff-witness
reACK jeanpablojp
#35901
wallet: Fix ScanForWalletTransactions missing tx when look-ahead pool expands mid-block
ACK jeanpablojp
#35948
init: correct first-run disk space estimate
ACK mercie-ux

2026-08-11

#35939
init: reject -noconnect double-negatives that become -connect=1
Concept ACK jeanpablojp
#35950
Update leveldb subtree to latest master
Code Review ACK l0rinc
#35949
miner: Enforce Murch-Zawy rule (BIP54)
Concept ACK l0rinc
#35930
wallet: post-#35501 cleanups in CWalletTx
ACK vicjuma
#35930
wallet: post-#35501 cleanups in CWalletTx
ACK achow101
#35920
net_processing: Ignore MSG_WITNESS_TX entries from INV messages
Concept ACK fjahr
#35857
wallet: add BIP39 mnemonic support to addhdkey
Tested ACK Zeegaths
#35911
Warn on and add missing [[noreturn]]
Concept ACK stickies-v
#35859
wallet: use unsigned KDF iteration count
ACK l0rinc
#35859
wallet: use unsigned KDF iteration count
ACK l0rinc

2026-08-10

#35859
wallet: use unsigned KDF iteration count
ACK 151henry151
#35925
wallet, rpc: Exclude non-owned addresses from listreceivedby*
ACK achow101
#35919
p2p: avoid orphanage abort at high peer counts
ACK jeanpablojp
#35937
test: Append print_suppressions=0 to LSAN_OPTIONS, and suppress bitcoin-qt
ACK fanquake

2026-08-09

#35931
ci: Check DLL imports of cross-built `bitcoind.exe`
ACK jeanpablojp
#35936
net: reject oversized locators before allocating
ACK jeanpablojp
#35893
test: cover submitpackage other-wtxid for same-txid-diff-witness
Concept ACK instagibbs
#35933
psbt: don't abort on invalid MuSig2 derivations
ACK jeanpablojp

2026-08-08

#35925
wallet, rpc: Exclude non-owned addresses from listreceivedby*
ACK jeanpablojp
#35923
mempool: count unbroadcast txids in memory usage
ACK jeanpablojp
#35930
wallet: post-#35501 cleanups in CWalletTx
ACK jeanpablojp
#35924
Wallet, refactor: Remove orphaned EraseWatchOnly function
ACK jeanpablojp

2026-08-07

#35833
rpc,wallet: prevent user input injecting fake log lines
ACK achow101
#35930
wallet: post-#35501 cleanups in CWalletTx
ACK achow101
#35908
doc: Update NetBSD Build Guide
ACK fanquake
#35931
ci: Check DLL imports of cross-built `bitcoind.exe`
ACK maflcko
#35915
Release: Prepare "Open Transifex translations for `v32.0`" step
ACK fanquake
#35925
wallet, rpc: Exclude non-owned addresses from listreceivedby*
Concept ACK polespinasa
#35914
test, fuzz: Remove unused variables
ACK maflcko

2026-08-06

#35859
wallet: use unsigned KDF iteration count
ACK l0rinc
#35920
net_processing: Ignore MSG_WITNESS_TX entries from INV messages
Concept ACK l0rinc
#35872
rpc: avoid descriptor range counter overflow
ACK achow101
#35896
refactor: Default uint256::operator==, add operator<=>
ACK maflcko
#35896
refactor: Default uint256::operator==, add operator<=>
ACK purpleKarrot
#35902
zmq: Log bind error at Error level, abort startup on init error
Concept ACK pinheadmz
#35896
refactor: Default uint256::operator==, add operator<=>
ACK Sjors
#35896
refactor: Default uint256::operator==, add operator<=>
ACK optout21
#35885
ci: switch to a sourceware mirror for riscv
ACK maflcko
#35850
fuzz: Implement `connect_block` harness
Concept ACK brunoerg
#35896
refactor: Default uint256::operator==, add operator<=>
ACK Sjors
#35878
net_processing: process unique tx INVs only
ACK fjahr
#35912
doc: fix stale bitcoin_en.xlf reference
Concept ACK hebasto
#35896
refactor: Default uint256::operator==, add operator<=>
ACK purpleKarrot
#35909
rest: Allow fetching stale header
Concept ACK sedited
#35878
net_processing: process unique tx INVs only
ACK ajtowns

2026-08-05

#35888
net: reject oversized outbound messages
Concept ACK ajtowns
#35896
refactor: Default uint256::operator==, add operator<=>
ACK purpleKarrot
#35885
ci: switch to a sourceware mirror for riscv
Concept ACK fanquake
#35852
scripted-diff: Use inline const(expr) over static constexpr in headers
reACK l0rinc
#35878
net_processing: process unique tx INVs only
Concept ACK yuvicc

2026-08-04

#35884
util: set os-level thread names on Windows
Concept ACK l0rinc
#35875
ci: Fix NetBSD SDK download failure, Temp. remove riscv32 from GHA
ACK l0rinc
#35878
net_processing: process unique tx INVs only
Concept ACK darosior
#35878
net_processing: process unique tx INVs only
Concept ACK fjahr
#35881
iwyu: Fix warnings in `src/consensus` and treat them as errors
ACK maflcko
#35880
fuzz: don't connman.ReceiveMsgFrom oversized msg
ACK maflcko
#35867
test: classify SOCKS5 peers via getpeerinfo addrbind
Concept ACK instagibbs
#35871
refactor: Annotate `MakeAndPushFeature` with `[[maybe_unused]]`
ACK ajtowns

2026-08-03

#35850
fuzz: Implement `connect_block` harness
Concept ACK Crypt-iQ
#35871
refactor: Annotate `MakeAndPushFeature` with `[[maybe_unused]]`
ACK maflcko
#35870
guix: move `python-minimal` to Linux GUI build
ACK maflcko
#35869
lint: (re-)add contrib/guix for Python linting
ACK maflcko

2026-08-02

#35866
test: Verify unwelcome RPC clients are rejected before reading their requests
utACK benediktrk
#35866
test: Verify unwelcome RPC clients are rejected before reading their requests
Concept ACK pinheadmz

2026-08-01

#35859
wallet: use unsigned KDF iteration count
ACK 151henry151

2026-07-31

#35832
p2p: avoid block disk reads on unnecessary requests
ACK 151henry151
#35852
scripted-diff: Use inline const(expr) over static constexpr in headers
ACK fanquake

2026-07-30

#35852
scripted-diff: Use inline const(expr) over static constexpr in headers
Concept ACK fanquake
#35847
test: move more tests to `baseindex_tests` and run them for all indexes
Concept ACK furszy
#35847
test: move more tests to `baseindex_tests` and run them for all indexes
Concept ACK fjahr
#35838
qa: Enable `interface_gui.py` on macOS
ACK maflcko
#35838
qa: Enable `interface_gui.py` on macOS
ACK maflcko
#35837
rpc: fail scanblocks when block filter range is unavailable
Concept ACK maflcko

2026-07-29

#35831
argsman, cli: Allow options after non-option arguments (GNU-style)
Concept ACK w0xlt
#35832
p2p: avoid block disk reads on unnecessary requests
Concept ACK 151henry151