Looking for NACKs? → nackamoto.com

Last updated at 2026-06-01 13:59 UTC

2026-06-01

#35410
net: use the proxy if overriden when doing v2->v1 reconnections (with functional test)
reACK Crypt-iQ

2026-05-30

#35395
doc: Improve test suite dependencies documentation
Concept ACK l0rinc
#35372
refactor: Enhance type safety in overflow operations
Code Review ACK l0rinc

2026-05-29

#35402
doc: Compress doc/build-unix.md dependency package names into table
ACK achow101
#35417
ci: isolate container test networks
Concept ACK fanquake
#35410
net: use the proxy if overriden when doing v2->v1 reconnections (with functional test)
ACK Crypt-iQ
#35413
fuzz: PrivateBroadcast
Concept ACK nervana21
#35335
Make deployment configuration available outside of regtest in unit tests
utACK edilmedeiros
#35404
wallet: allow anti-fee-sniping in sendall RPC while not relying on RBF default
ACK maflcko
#35385
test: restore JSONRPCException error format
ACK maflcko
#35215
coins: use jumboblock SipHash-1-3 for hashing CCoinsMap keys
Concept ACK optout21
#35215
coins: use jumboblock SipHash-1-3 for hashing CCoinsMap keys
Concept ACK sedited
#35408
ci: 35378 followups
ACK maflcko
#35286
rpc: add testsubmitpackage for 1p1c test submissions
Concept ACK ismaelsadeeq

2026-05-28

#35179
test: Add importdescriptors rpc error coverage
ACK achow101
#35381
wallet, test: optinrbf deprecation followups
ACK achow101
#35312
kernel: assert invalid buffer preconditions in `btck_*_create` functions
ACK sedited
#35381
wallet, test: optinrbf deprecation followups
ACK maflcko
#35378
ci: switch to warp runners
ACK maflcko
#35378
ci: switch to warp runners
ACK m3dwards
#35400
doc: Remove good_first_issue.yml, Reword "Getting started" section
ACK stickies-v
#35402
doc: Compress doc/build-unix.md dependency package names into table
Concept ACK willcl-ark
#35396
ci: Rewrite broken wrap-valgrind.sh to .py
Concept ACK fanquake
#35386
doc: add an AI contribution policy
utACK Sjors
#35400
doc: Remove good_first_issue.yml, Reword "Getting started" section
Concept ACK fanquake

2026-05-27

#35378
ci: switch to warp runners
Concept ACK m3dwards
#35397
ci: add OpenBSD Clang cross job
Concept ACK sedited
#35378
ci: switch to warp runners
Concept ACK achow101
#35394
test: remove unnecessary rpc calls from feature_dbcrash
ACK maflcko
#35391
test: Use operator<< for time_points instead of manual TickSinceEpoch
Concept ACK Sjors
#35372
refactor: Enhance type safety in overflow operations
ACK maflcko
#35206
doc: fix doxygen links to threads in developer-notes.md
ACK fanquake
#35378
ci: switch to warp runners
Concept ACK fanquake
#35321
p2p: Misbehave on invalid compact block in optimistic reconstruction
Concept ACK davidgumberg

2026-05-26

#35380
kernel: expose witness stack and scriptSig for btck_TransactionInput
Concept ACK w0xlt
#35375
doc: Add Nix build notes
Concept ACK ekzyis
#35372
refactor: Enhance type safety in overflow operations
ACK winterrdog
#35386
doc: add an AI contribution policy
Concept ACK achow101
#35380
kernel: expose witness stack and scriptSig for btck_TransactionInput
Concept ACK theStack
#35337
doc: add feature deprecation and removal process to developer notes
ACK stickies-v
#35216
qa: Support `get_bind_addrs` and `feature_bind_extra` on illumos
Concept ACK fanquake
#35296
doc: Fix broken links in dev notes, move sections
ACK fanquake
#35337
doc: add feature deprecation and removal process to developer notes
ACK polespinasa
#35337
doc: add feature deprecation and removal process to developer notes
ACK maflcko
#35251
wallet: Fix for duplicate external signers case
ACK achow101

2026-05-25

#35372
refactor: Enhance type safety in overflow operations
Concept ACK sedited

2026-05-24

#35368
tracing: add block header and compact block tracepoints
Concept ACK 0xB10C
#35173
util: shorten thread names to avoid Linux truncation
ACK winterrdog

2026-05-22

#35351
net: Disallow invalid HeadersSyncState due to lagging clock
Concept ACK w0xlt
#35359
blockstorage: Remove cs_LastBlockFile recursive mutex
Concept ACK w0xlt
#35359
blockstorage: Remove cs_LastBlockFile recursive mutex
ACK stickies-v
#35356
ci: Test build dir with spaces
Concept ACK hebasto
#35348
ci: switch to GitHub cache for all runners
ACK maflcko

2026-05-21

#35335
Make deployment configuration available outside of regtest in unit tests
Concept ACK willcl-ark
#35350
test: suppress ECONNABORTED in wait_for_rpc_connection on Windows
ACK maflcko
#35349
ci: Fix `path` input for vcpkg downloads cache
ACK maflcko
#35316
musig: Reject empty pubkey list in GetMuSig2KeyAggCache
ACK achow101
#35187
kernel: Add non-utxo set block validation to API
ACK w0xlt
#35333
qa: use NORMAL_GBT_REQUEST_PARAMS consistently in functional tests
ACK fanquake
#35141
fuzz: apply node context reset pattern to p2p_handshake
ACK maflcko
#35344
kernel: improve BITCOINKERNEL_WARN_UNUSED_RESULT usage
Concept ACK yuvicc
#35254
crypto: cleanse HMAC stack buffers after use and ChainCode
ACK optout21
#35334
test: Allow --usecli in more tests
Concept ACK fanquake
#35338
qa: regenerate hardcoded regtest chain for kernel lib unit tests
ACK alexanderwiederin
#35251
wallet: Fix for duplicate external signers case
Concept ACK l0rinc
#35251
wallet: Fix for duplicate external signers case
ACK l0rinc
#35333
qa: use NORMAL_GBT_REQUEST_PARAMS consistently in functional tests
ACK maflcko

2026-05-20

#35205
kernel,node: clean up `dbcache` helpers and add kernel API
Concept ACK sedited
#35335
Make deployment configuration available outside of regtest in unit tests
Concept ACK sedited
#35228
wallet: use `outpoint` when estimating input size
ACK w0xlt
#35333
qa: use NORMAL_GBT_REQUEST_PARAMS consistently in functional tests
ACK maflcko
#35295
validation: fetch block input prevouts in parallel during ConnectBlock
Concept ACK rkrux
#35328
test: restore assertion that tx contains exactly 2500 sigops
Code Review ACK l0rinc
#35302
Silent Payments: Sending (take 2)
Concept ACK rkrux

2026-05-19

#35303
policy: fix negative CFeeRate::ToString() formatting
Tested ACK winterrdog
#35301
Silent Payments: Implement bip352 (take 2)
Concept ACK rkrux
#35301
Silent Payments: Implement bip352 (take 2)
Concept ACK w0xlt
#35323
private broadcast: disallow tor connection through exit node
Concept ACK w0xlt
#35208
net: cap future-MTP headers commitments
utACK dergoegge
#35323
private broadcast: disallow tor connection through exit node
Concept ACK willcl-ark
#35220
fuzz: connman: strengthen assertions and extend coverage
Concept ACK nervana21
#35297
p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll
ACK shuv-amp
#35294
wallet: Update tx chain state during loading during AttachChain instead of before
ACK shuv-amp
#35310
test: cover PSBT unknown field merging
ACK mercie-ux
#35297
p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll
Code Review ACK xyzconstant

2026-05-18

#35141
fuzz: apply node context reset pattern to p2p_handshake
Concept ACK nervana21

2026-05-17

#35254
crypto: cleanse HMAC stack buffers after use and ChainCode
ACK winterrdog

2026-05-15

#35285
bench: add benchmark for GetMappedAS()
ACK achow101
#35285
bench: add benchmark for GetMappedAS()
ACK sipa
#35285
bench: add benchmark for GetMappedAS()
ACK l0rinc

2026-05-14

#35289
fuzz: Fix timeout in `txorphan`
ACK instagibbs
#35289
fuzz: Fix timeout in `txorphan`
ACK maflcko
#35285
bench: add benchmark for GetMappedAS()
ACK jurraca
#35288
ci: Debian Trixie -> Ubuntu 26.04
Concept ACK fanquake
#35197
guix: add -Wl,--icf=safe to darwin build
ACK davidgumberg
#35174
test: clean up threadpool test types
ACK ferminquant

2026-05-13

#35228
wallet: use `outpoint` when estimating input size
ACK achow101
#35270
doc: Document minimum versions for Xcode CLT and MSVC
ACK l0rinc
#35156
dbwrapper: reuse scratch `DataStream` buffers
ACK achow101
#35274
doc: clarify libfuzzer-nosan preset uses build_fuzz_nosan dir
ACK maflcko
#35270
doc: Document minimum versions for Xcode CLT and MSVC
reACK polespinasa
#35284
fuzz: use ImmediateBackgroundTaskRunner to silence DEBUG_LOCKORDER
ACK maflcko
#35283
doc: mention -DWITH_ZMQ=ON in BSD build guides
ACK maflcko
#35249
sync: guard semaphore grant self-move
Tested ACK ferminquant
#35279
psbt, test: remove address type restrictions in test
ACK kevkevinpal
#35274
doc: clarify libfuzzer-nosan preset uses build_fuzz_nosan dir
ACK l0rinc
#35189
kernel: document validation state outputs as overwritten in-place
ACK yuvicc
#35277
ci: Enable ruff ambiguous-unicode-character checks
Concept ACK fanquake

2026-05-12

#35254
crypto: cleanse HMAC stack buffers after use and ChainCode
Concept ACK sedited
#35221
BIP 434 Support: Peer feature negotiation
Concept ACK w0xlt
#35267
rpc: make getprivatebroadcastinfo fail if privatebroadcast is not enabled
Concept ACK w0xlt
#35189
kernel: document validation state outputs as overwritten in-place
ACK alexanderwiederin
#35242
doc: mention -stdinwalletpassphrase in walletpassphrase(change) help
ACK mercie-ux

2026-05-11

#35266
rpc, wallet: add an option to not load the wallet after migrating
Concept ACK w0xlt
#35264
doc: add LLM section to CONTRIBUTING.md
Concept ACK sedited
#35182
Replace libevent with our own HTTP and socket-handling implementation
Concept ACK 0xB10C
#35183
doc: recommend script_flags instead of deployments.taproot
ACK maflcko

2026-05-10

#35252
net: send decoy transactions via private broadcast
Concept ACK kevkevinpal
#35241
cmake: Set `CTEST_NIGHTLY_START_TIME` for CDash Nightly pipelines
ACK purpleKarrot

2026-05-09

#35251
wallet: Fix for duplicate external signers case
ACK kevkevinpal
#35249
sync: guard semaphore grant self-move
ACK kevkevinpal
#35251
wallet: Fix for duplicate external signers case
Tested ACK l0rinc

2026-05-08

#35241
cmake: Set `CTEST_NIGHTLY_START_TIME` for CDash Nightly pipelines
ACK ferminquant
#35183
doc: recommend script_flags instead of deployments.taproot
ACK ferminquant
#35242
doc: mention -stdinwalletpassphrase in walletpassphrase(change) help
ACK ferminquant
#35233
wallet: keep enumerating after duplicate signers
ACK kevkevinpal
#35182
Replace libevent with our own HTTP and socket-handling implementation
Concept ACK fanquake
#35235
contrib: mv verify-commits/pre-push-hook.sh to maintainer tools repo
Code Review ACK l0rinc

2026-05-07

#35235
contrib: mv verify-commits/pre-push-hook.sh to maintainer tools repo
ACK kevkevinpal
#35236
doc: typo roundup
ACK kevkevinpal
#35227
wallet: check the final BDB page LSN during migration
ACK achow101
#35235
contrib: mv verify-commits/pre-push-hook.sh to maintainer tools repo
ACK achow101
#35210
[31.x] validation: correct lifetime of precomputed tx data
ACK fanquake
#35219
doc: Add my key to SECURITY.md
Concept ACK l0rinc

2026-05-06

#35223
refactor: [rpc] Remove confusing and brittle integral casts (take 3)
ACK fjahr
#35219
doc: Add my key to SECURITY.md
ACK achow101
#35222
cmake: add CTestConfig.cmake
ACK maflcko
#35221
BIP 434 Support: Peer feature negotiation
Concept ACK sedited
#35222
cmake: add CTestConfig.cmake
ACK purpleKarrot
#35221
BIP 434 Support: Peer feature negotiation
Concept ACK fjahr
#35216
qa: Support `get_bind_addrs` and `feature_bind_extra` on illumos
Code Review ACK l0rinc
#35211
[30.x] validation: correct lifetime of precomputed tx data
ACK achow101
#35213
[28.x] validation: correct lifetime of precomputed tx data
ACK achow101
#35212
[29.x] validation: correct lifetime of precomputed tx data
ACK achow101
#35214
[28.x] Backports
ACK achow101
#35209
validation: correct lifetime of precomputed tx data
ACK achow101
#35209
validation: correct lifetime of precomputed tx data
ACK maflcko

2026-05-05

#35177
test: use MiniWallet for getblockstats test data generation
ACK mercie-ux
#35209
validation: correct lifetime of precomputed tx data
ACK theuni
#35209
validation: correct lifetime of precomputed tx data
Concept ACK maflcko

2026-05-04

#35174
test: clean up threadpool test types
Concept ACK winterrdog
#35206
doc: fix doxygen links to threads in developer-notes.md
ACK ViniciusCestarii
#35202
ci: restore sockets in `i686, no IPC` job
ACK maflcko
#35185
wallet: fix importdescriptors batch abort on timestamp error
Concept ACK kevkevinpal
#35202
ci: restore sockets in `i686, no IPC` job
ACK kevkevinpal

2026-05-02

#35193
test: avoid non-loopback network traffic from node_init_tests/init_test
ACK fjahr
#35165
cmake: Remove NetBSD-specific workaround from `add_boost_if_needed`
ACK fanquake

2026-05-01

#35156
dbwrapper: reuse scratch `DataStream` buffers
ACK jmoik
#35187
kernel: Add non-utxo set block validation to API
ACK ismaelsadeeq
#35191
txdb: handle malformed first coin cursor key
utACK junbyjun1238

2026-04-30

#35186
util, iwyu: Add missed header
ACK pinheadmz
#35185
wallet: fix importdescriptors batch abort on timestamp error
Concept ACK polespinasa
#35161
consensus: document merkle mutation root invariant
Concept ACK w0xlt
#35173
util: shorten thread names to avoid Linux truncation
Concept ACK naiyoma

2026-04-29

#35175
multi_index: fix compilation failure with boost >= 1.91
ACK maflcko
#35176
ci: reduce ccache size on GHA runners
Concept ACK fanquake

2026-04-28

#35165
cmake: Remove NetBSD-specific workaround from `add_boost_if_needed`
Tested ACK davidgumberg
#35173
util: shorten thread names to avoid Linux truncation
Concept ACK andrewtoth
#35164
test: cover P2SH sigop counting in test_witness_sigops
ACK haishmg
#35170
test: Better test coverage for legacy ParseHDKeypath()
ACK haishmg
#35167
Convert check-deps.sh to python
ACK sedited

2026-04-27

#35167
Convert check-deps.sh to python
Concept ACK sedited
#35149
doc: clarify clang-tidy in developer notes
Code Review ACK l0rinc

2026-04-24

#35148
refactor: Remove confusing DataStream::in_avail() alias
Code Review ACK l0rinc

2026-04-22

#35140
ci: Temporarily move CI from Cirrus to GHA
ACK m3dwards
#35140
ci: Temporarily move CI from Cirrus to GHA
Concept ACK m3dwards
#35138
doc: add missed advisory to 31.0 rel notes
ACK achow101
#35138
doc: add missed advisory to 31.0 rel notes
ACK darosior

2026-04-21

#35132
doc: update release process to mention security advisories pre-announcements
ACK achow101